From: Jeff Garzik <jgarzik@pobox.com>
To: mikem@beardog.cca.cpqcorp.net
Cc: akpm@osdl.org, axboe@suse.de, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: cciss update [1/2] updates our SCSI support to not use deprecated headers
Date: Wed, 13 Oct 2004 17:21:05 -0400 [thread overview]
Message-ID: <20041013212105.GA4438@havoc.gtf.org> (raw)
In-Reply-To: <20041013211302.GA9866@beardog.cca.cpqcorp.net>
On Wed, Oct 13, 2004 at 04:13:02PM -0500, mike.miller@hjp.com wrote:
> @@ -552,11 +547,12 @@ cciss_scsi_setup(int cntl_num)
> static void
> complete_scsi_command( CommandList_struct *cp, int timeout, __u32 tag)
> {
> - Scsi_Cmnd *cmd;
> + struct scsi_cmnd *cmd;
> ctlr_info_t *ctlr;
> u64bit addr64;
> ErrorInfo_struct *ei;
>
> + cmd = kmalloc(sizeof(struct scsi_cmnd), GFP_KERNEL);
> ei = cp->err_info;
>
This can get called from the interrupt handler, so GFP_KERNEL won't
work. GFP_ATOMIC works, but you need to check kmalloc() return for
NULL.
Jeff
next prev parent reply other threads:[~2004-10-13 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-13 21:13 mike.miller
2004-10-13 21:21 ` Jeff Garzik [this message]
2004-10-13 21:36 ` mikem
[not found] ` <1097704228.3062.1.camel@localhost.localdomain>
2004-10-13 22:33 ` cciss update [1/2] updates our SCSI support to not use deprecated headers pass 3 mike.miller
2004-10-14 0:08 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041013212105.GA4438@havoc.gtf.org \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®