From: Francois Romieu <romieu@fr.zoreil.com>
To: Hanna Linder <hannal@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@lists.osdl.org>,
chas@cmf.nrl.navy.mil, greg@kroah.com
Subject: Re: [KJ] [PATCH 2.6] firestream.c replace pci_find_device with pci_get_device
Date: Thu, 14 Oct 2004 00:33:40 +0200 [thread overview]
Message-ID: <20041013223340.GA32276@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <196320000.1097705843@w-hlinder.beaverton.ibm.com>
Hanna Linder <hannal@us.ibm.com> :
[...]
Too complicated.
Removal of dead code.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
diff -puN drivers/atm/firestream.c~firestream-10 drivers/atm/firestream.c
--- linux-2.6.9-rc3/drivers/atm/firestream.c~firestream-10 2004-10-14 00:28:36.000000000 +0200
+++ linux-2.6.9-rc3-fr/drivers/atm/firestream.c 2004-10-14 00:29:18.000000000 +0200
@@ -2012,66 +2012,6 @@ void __devexit firestream_remove_one (st
func_exit ();
}
-
-#if 0
-int __init fs_detect(void)
-{
- struct pci_dev *pci_dev;
- int devs = 0;
-
- func_enter ();
- pci_dev = NULL;
- while ((pci_dev = pci_find_device(PCI_VENDOR_ID_FUJITSU_ME,
- PCI_DEVICE_ID_FUJITSU_FS50,
- pci_dev))) {
- if (fs_register_and_init (pci_dev, &fs_pci_tbl[0]))
- break;
- devs++;
- }
-
- while ((pci_dev = pci_find_device(PCI_VENDOR_ID_FUJITSU_ME,
- PCI_DEVICE_ID_FUJITSU_FS155,
- pci_dev))) {
- if (fs_register_and_init (pci_dev, FS_IS155))
- break;
- devs++;
- }
- func_exit ();
- return devs;
-}
-#else
-
-#if 0
-int __init init_PCI (void)
-{ /* Begin init_PCI */
-
- int pci_count;
- printk ("init_PCI\n");
- /*
- memset (&firestream_driver, 0, sizeof (firestream_driver));
- firestream_driver.name = "firestream";
- firestream_driver.id_table = firestream_pci_tbl;
- firestream_driver.probe = fs_register_and_init;
- */
- pci_count = pci_register_driver (&firestream_driver);
-
- if (pci_count <= 0) {
- pci_unregister_driver (&firestream_driver);
- pci_count = 0;
- }
-
- return(pci_count);
-
-} /* End init_PCI */
-#endif
-#endif
-
-/*
-#ifdef MODULE
-#define firestream_init init_module
-#endif
-*/
-
static struct pci_device_id firestream_pci_tbl[] = {
{ PCI_VENDOR_ID_FUJITSU_ME, PCI_DEVICE_ID_FUJITSU_FS50,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, FS_IS50},
_
next prev parent reply other threads:[~2004-10-13 22:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-13 22:15 [PATCH 2.6] ambassador.c " Hanna Linder
2004-10-13 22:17 ` [PATCH 2.6] firestream.c " Hanna Linder
2004-10-13 22:33 ` Francois Romieu [this message]
2004-10-13 22:18 ` [PATCH 2.6] fore200e.c " Hanna Linder
2004-10-14 8:34 ` [KJ] " Christoph Hellwig
2004-10-14 14:08 ` chas williams (contractor)
2004-10-13 22:19 ` [PATCH 2.6] horizon.c: " Hanna Linder
2004-10-13 22:20 ` [PATCH 2.6] zatm.c: " Hanna Linder
2004-10-13 22:53 ` Francois Romieu
2004-10-13 23:15 ` Hanna Linder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041013223340.GA32276@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®