From: Chuck Ebbert <76306.1226@compuserve.com>
To: Dave Jones <davej@redhat.com>
Cc: Daniele Pizzoni <auouo@tin.it>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: janitoring printk with no KERN_ constants, kill all defaults?
Date: Fri, 15 Oct 2004 13:06:48 -0400 [thread overview]
Message-ID: <200410151311_MC3-1-8C48-9C05@compuserve.com> (raw)
Dave Jones wrote:
> Consider this..
>
> printk (KERN_INFO "blah blah ");
> if (foo)
> printk ("%s", stringptr);
> else
> printk ("%d", number);
> printk ("\n");
>
> There's nothing wrong with any of those printk's, so you
> cannot do the checks you mention above.
But other code can call printk in between on SMP and/or preempt systems,
making a mess of the log. This is a(n old) problem that should be
fixed once and for all, AFAIC.
--Chuck Ebbert 15-Oct-04 13:05:20
next reply other threads:[~2004-10-15 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 17:06 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-15 15:44 Daniele Pizzoni
2004-10-15 15:46 ` Dave Jones
2004-10-15 17:20 ` Daniele Pizzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410151311_MC3-1-8C48-9C05@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=auouo@tin.it \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®