From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Andrew Grover <andy.grover@gmail.com>
Cc: Matthias Urlichs <smurf@smurf.noris.de>, linux-kernel@vger.kernel.org
Subject: Re: 4level page tables for Linux II
Date: Fri, 15 Oct 2004 15:28:23 +0200 [thread overview]
Message-ID: <20041015132823.GA26048@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <c0a09e5c041014185545517031@mail.gmail.com>
On Thu, 14 October 2004 18:55:20 -0700, Andrew Grover wrote:
> On Thu, 14 Oct 2004 18:57:24 +0200, Matthias Urlichs
> > Disagree. Rather strongly in fact.
> >
> > It's probably OK if you already know the stuff and have been hacking
> > Linux' mm for years already, but if you try to learn how things work by
> > actually looking at the code..?
> >
> > Just number them. Let pd1 point to pages, pd2 to pd1 entries, and so on.
> > (Level zero is the actual pages.)
>
> I happen to agree, but surely this can be addressed at our leisure,
> after pml4 is in.
>
> Maybe a good task for the kernel janitors, if we all agree more
> sensible names are desirable.
Please don't. Current names may be odd, but at least they are
sufficiently different from one another. 4 names that only differ in
a single number are an invitation for typos, thinkos and similar
confusion.
Whenever I notice a mess like that in any piece of software I change
it to make the difference bigger, not smaller. Have you ever been
slightly distracted, kept typing anyway and it compiled just fine,
creating a subtle bug? ;)
Jörn
--
When I am working on a problem I never think about beauty. I think
only how to solve the problem. But when I have finished, if the
solution is not beautiful, I know it is wrong.
-- R. Buckminster Fuller
next prev parent reply other threads:[~2004-10-15 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-13 3:36 Albert Cahalan
2004-10-13 7:22 ` Andi Kleen
2004-10-13 21:42 ` Albert Cahalan
2004-10-14 16:57 ` Matthias Urlichs
2004-10-15 1:55 ` Andrew Grover
2004-10-15 13:28 ` Jörn Engel [this message]
2004-10-15 13:55 ` Matthias Urlichs
2004-10-15 23:39 ` Jörn Engel
2004-10-17 5:54 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2004-10-12 13:59 4level page tables for Linux Andi Kleen
2004-10-12 18:48 ` Dave Hansen
2004-10-12 19:03 ` Andi Kleen
2004-10-12 19:08 ` 4level page tables for Linux II Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041015132823.GA26048@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=andy.grover@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®