mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "H. J. Lu" <hjl@lucon.org>
Cc: linux-kernel@vger.kernel.org, ebiederm@xmission.com
Subject: Re: 2.6.9 kexec patch causes kernel panic during reboot on x86-64
Date: Fri, 15 Oct 2004 14:45:28 -0700	[thread overview]
Message-ID: <20041015144528.2556d00c.akpm@osdl.org> (raw)
In-Reply-To: <20041015214013.GA6555@lucon.org>

"H. J. Lu" <hjl@lucon.org> wrote:
>
> 2.6.9 kexec patch adds a call to find_isa_irq_pin in disable_IO_APIC.
>  But find_isa_irq_pin is marked __init on x86-64, which leads to
>  kernel panic. This patch should fix it.
> 
> 
>  H.J.
>  --- linux-2.6.8/arch/x86_64/kernel/io_apic.c.init	2004-10-14 16:21:44.000000000 -0700
>  +++ linux-2.6.8/arch/x86_64/kernel/io_apic.c	2004-10-15 14:34:53.615495099 -0700
>  @@ -332,7 +332,7 @@ static int __init find_irq_entry(int api
>   /*
>    * Find the pin to which IRQ[irq] (ISA) is connected
>    */
>  -static int __init find_isa_irq_pin(int irq, int type)
>  +static int find_isa_irq_pin(int irq, int type)
>   {

Yup, there are several such fixups needed.  See
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.9-rc4/2.6.9-rc4-mm1/broken-out/assign_irq_vector-section-fix.patch.

If you're testing kexec you might be better off using 2.6.9-rc4-mm1 (minus
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.9-rc4/2.6.9-rc4-mm1/broken-out/optimize-profile-path-slightly.patch)
because it has the latest kexec version (it had better be!) and whatever
fixups people have found against it.


  reply	other threads:[~2004-10-15 21:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-15 21:40 H. J. Lu
2004-10-15 21:45 ` Andrew Morton [this message]
2004-10-15 21:47 ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041015144528.2556d00c.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=hjl@lucon.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®