From: Sam Ravnborg <sam@ravnborg.org>
To: Tejun Heo <tj@home-tj.org>
Cc: linux-kernel@vger.kernel.org, kai@germaschewski.name
Subject: Re: [PATCH] patsubstfor LOCALVERSION and -fno-omit-frame-pointer
Date: Sun, 17 Oct 2004 02:01:26 +0200 [thread overview]
Message-ID: <20041017000126.GD15006@mars.ravnborg.org> (raw)
In-Reply-To: <20040912093635.GD13359@home-tj.org>
On Sun, Sep 12, 2004 at 06:36:35PM +0900, Tejun Heo wrote:
> (** Sorry, I'm resending this mail. I had written the subject in the
> Reply-To field. **)
>
> Hello, I'm attaching two patches for the top Makefile.
>
> The first patch modifies LOCALVERSION definition such taht it uses
> patsubst instead of subst to remove surrounding double quotes from
> CONFIG_LOCALVERSION. This helps syntax-highlighting editors.
>
> The second patch addes -fno-omit-frame-pointer to CFLAGS when
> CONFIG_FRAME_POINTER is set. My gcc (gcc-3.3.4 Debian 1:3.3.4-11)
> automatically turns on -fomit-frame-pointer when -O2 is specified and
> thus breaks CONFIG_FRAME_POINTER option. I'm not sure if other
> versions of gcc wouldn't choke with -fno-omit-frame-pointer. My 2.95
> (2.95.4) seems to be OK though.
Applied both.
Next time please send a single patch/mail.
Sam
prev parent reply other threads:[~2004-10-16 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-12 9:36 Tejun Heo
2004-10-17 0:01 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041017000126.GD15006@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=kai@germaschewski.name \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@home-tj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®