mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "K.R. Foley" <kr@cybsft.com>
Cc: Mark_H_Johnson@raytheon.com, linux-kernel@vger.kernel.org,
	Lee Revell <rlrevell@joe-job.com>,
	Rui Nuno Capela <rncbc@rncbc.org>, Bill Huey <bhuey@lnxw.com>,
	Adam Heath <doogie@debian.org>,
	Florian Schmidt <mista.tapas@gmx.net>
Subject: Re: [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U5
Date: Mon, 18 Oct 2004 21:24:19 +0200	[thread overview]
Message-ID: <20041018192419.GA7076@elte.hu> (raw)
In-Reply-To: <4173F879.40102@cybsft.com>


* K.R. Foley <kr@cybsft.com> wrote:

> Well you just beat me with that one. :) And here is another for
> aha152x.

> -       DECLARE_MUTEX_LOCKED(sem);
> +       DECLARE_MUTEX(sem);

almost - the full patch is the one below. (DECLARE_MUTEX() initializes
the mutex as unlocked, so there's a difference.)

	Ingo

--- linux/drivers/scsi/aha152x.c.orig
+++ linux/drivers/scsi/aha152x.c
@@ -1160,11 +1160,12 @@ static void timer_expired(unsigned long 
 static int aha152x_device_reset(Scsi_Cmnd * SCpnt)
 {
 	struct Scsi_Host *shpnt = SCpnt->device->host;
-	DECLARE_MUTEX_LOCKED(sem);
+	DECLARE_MUTEX(sem);
 	struct timer_list timer;
 	int ret, issued, disconnected;
 	unsigned long flags;
 
+	init_MUTEX_LOCKED(&sem);
 #if defined(AHA152X_DEBUG)
 	if(HOSTDATA(shpnt)->debug & debug_eh) {
 		printk(INFO_LEAD "aha152x_device_reset(%p)", CMDINFO(SCpnt), SCpnt);

  reply	other threads:[~2004-10-18 19:26 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-18 16:24 Mark_H_Johnson
2004-10-18 16:54 ` Ingo Molnar
2004-10-18 17:08   ` K.R. Foley
2004-10-18 19:24     ` Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-10-11 21:59 [patch] VP-2.6.9-rc4-mm1-T5 Ingo Molnar
2004-10-12  9:15 ` [patch] VP-2.6.9-rc4-mm1-T6 Ingo Molnar
2004-10-12 12:33   ` Ingo Molnar
2004-10-12 19:54     ` [patch] VP-2.6.9-rc4-mm1-T8 Ingo Molnar
2004-10-13  6:15       ` [patch] VP-2.6.9-rc4-mm1-T9 Ingo Molnar
2004-10-14  0:24         ` [patch] Real-Time Preemption, -VP-2.6.9-rc4-mm1-U0 Ingo Molnar
2004-10-14 14:31           ` [patch] Real-Time Preemption, -VP-2.6.9-rc4-mm1-U1 Ingo Molnar
2004-10-14 23:42             ` [patch] Real-Time Preemption, -VP-2.6.9-rc4-mm1-U2 Ingo Molnar
2004-10-15 10:26               ` [patch] Real-Time Preemption, -VP-2.6.9-rc4-mm1-U3 Ingo Molnar
2004-10-16 15:33                 ` [patch] Real-Time Preemption, -VP-2.6.9-rc4-mm1-U4 Ingo Molnar
2004-10-18 14:50                   ` [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U5 Ingo Molnar
2004-10-18 15:58                     ` Jason Munro
2004-10-18 17:08                     ` Adam Heath
2004-10-18 17:12                       ` Ingo Molnar
2004-10-18 17:57                     ` Adam Heath
2004-10-18 18:18                       ` Ingo Molnar
2004-10-18 20:58                         ` Adam Heath
2004-10-18 21:06                           ` Ingo Molnar
2004-10-18 21:21                             ` Adam Heath
2004-10-18 18:44                     ` K.R. Foley
2004-10-18 18:49                       ` Ingo Molnar
2004-10-18 19:17                         ` K.R. Foley
2004-10-18 19:32                     ` Bill Huey
2004-10-18 19:34                       ` Bill Huey
2004-10-18 19:36                       ` Ingo Molnar
2004-10-18 19:40                         ` Bill Huey
2004-10-18 19:46                           ` Ingo Molnar
2004-10-18 19:52                             ` Bill Huey
2004-10-19  1:27                     ` Adam Heath
2004-10-19  8:09                     ` Thomas Gleixner
2004-10-19  8:12                     ` Thomas Gleixner
2004-10-19  9:04                       ` Ingo Molnar
2004-10-19  9:03                         ` Thomas Gleixner
2004-10-19  9:34                           ` Ingo Molnar
2004-10-19  9:50                             ` Ingo Molnar
2004-10-19 10:12                             ` Thomas Gleixner
2004-10-19 11:07                               ` Ingo Molnar
2004-10-19 11:14                                 ` Thomas Gleixner
2004-10-19 10:34                     ` Michal Schmidt
2004-10-19 12:57                     ` Kevin Hilman
2004-10-19 13:04                       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041018192419.GA7076@elte.hu \
    --to=mingo@elte.hu \
    --cc=Mark_H_Johnson@raytheon.com \
    --cc=bhuey@lnxw.com \
    --cc=doogie@debian.org \
    --cc=kr@cybsft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mista.tapas@gmx.net \
    --cc=rlrevell@joe-job.com \
    --cc=rncbc@rncbc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome