From: Werner Almesberger <werner@almesberger.net>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: "Andrew Morton" <akpm@osdl.org>,
ak@suse.de, "Jaakko Hyvätti" <jaakko.hyvatti@iki.fi>
Subject: [PATCH] no TIOCSBRK/TIOCCBRK in ia32 emulation on amd64
Date: Tue, 19 Oct 2004 19:07:05 -0300 [thread overview]
Message-ID: <20041019190705.J18873@almesberger.net> (raw)
In ia32 emulation, the amd64 kernel refuses the ioctls TIOCSBRK
and TIOCCBRK with EINVAL. I've attached a patch that adds them to
the compatibility list.
Since all architectures have these ioctls ("m68knommu" inherits
them from "m68k", "um" from its host) and use the same code, I
think adding them to compat_ioctl.h is the correct choice (as
opposed to adding them to arch/x86_64/ia32/ia32_ioctl.c).
The patch is for 2.6.9. I've observed the problem the first time
in 2.6.7.
- Werner
---------------------------------- cut here -----------------------------------
Signed-off-by: Werner Almesberger <werner@almesberger.net>
--- linux-2.6.9/include/linux/compat_ioctl.h.orig 2004-10-19 18:52:50.406756352 -0300
+++ linux-2.6.9/include/linux/compat_ioctl.h 2004-10-19 18:56:34.057756232 -0300
@@ -23,6 +23,8 @@
COMPATIBLE_IOCTL(TCSETSW)
COMPATIBLE_IOCTL(TCSETSF)
COMPATIBLE_IOCTL(TIOCLINUX)
+COMPATIBLE_IOCTL(TIOCSBRK)
+COMPATIBLE_IOCTL(TIOCCBRK)
/* Little t */
COMPATIBLE_IOCTL(TIOCGETD)
COMPATIBLE_IOCTL(TIOCSETD)
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/
next reply other threads:[~2004-10-20 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 22:07 Werner Almesberger [this message]
2004-10-19 22:39 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041019190705.J18873@almesberger.net \
--to=werner@almesberger.net \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jaakko.hyvatti@iki.fi \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®