From: Christoph Hellwig <hch@infradead.org>
To: Amit Gud <amitgud1@gmail.com>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] Remove union u from linux/fs.h
Date: Wed, 20 Oct 2004 14:10:15 +0100 [thread overview]
Message-ID: <20041020131015.GB20287@infradead.org> (raw)
In-Reply-To: <2c59f00304102002135ca68dd0@mail.gmail.com>
On Wed, Oct 20, 2004 at 02:43:59PM +0530, Amit Gud wrote:
> Do we need the foolish-looking union with just single entry (void
> *generic_ip) in the struct inode linux/fs.h anymore? Why not remove
> it?
>
> This patch does that along with the changes in other parts of the
> kernel that references the union. Its compile-tested and applies
> cleanly to 2.6.9 vanilla.
I don't think we shoould do such purely cosmetic changes that break backwards
compatibility during stable series.
next prev parent reply other threads:[~2004-10-20 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 9:13 Amit Gud
2004-10-20 13:10 ` Christoph Hellwig [this message]
2004-10-20 13:28 ` Amit Gud
2004-10-20 14:53 ` David Woodhouse
2004-10-21 6:41 ` Amit Gud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020131015.GB20287@infradead.org \
--to=hch@infradead.org \
--cc=amitgud1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®