From: Dave Jones <davej@redhat.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Hanna Linder <hannal@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@lists.osdl.org>,
greg@kroah.com
Subject: Re: [KJ] [RFT 2.6] generic.c: replace pci_find_device with pci_get_device
Date: Wed, 20 Oct 2004 23:07:55 +0100 [thread overview]
Message-ID: <20041020220755.GA12553@redhat.com> (raw)
In-Reply-To: <20041020220242.GY16153@parcelfarce.linux.theplanet.co.uk>
On Wed, Oct 20, 2004 at 11:02:42PM +0100, Matthew Wilcox wrote:
> On Wed, Oct 20, 2004 at 11:51:17AM -0700, Hanna Linder wrote:
> > As pci_find_device is going away soon I have converted this file to use
> > pci_get_device instead. I have compile tested it. If anyone has this hardware
> > and could test it that would be great.
>
> Looks to me like this is a broken interface. We almost certainly want to
> pass the agp_device to agp_collect_device_status and agp_device_command,
> as noted in the comment to agp_collect_device_status. DaveJ?
It ain't pretty, but I probably won't find time to clean that up
any time soon. This doesn't impact Hanna's patch however.
Dave
prev parent reply other threads:[~2004-10-20 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 18:51 Hanna Linder
2004-10-20 22:02 ` [KJ] " Matthew Wilcox
2004-10-20 22:07 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020220755.GA12553@redhat.com \
--to=davej@redhat.com \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome