From: Dave Jones <davej@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <matthew@wil.cx>, Hanna Linder <hannal@us.ibm.com>,
davej@codemonkey.org.uk,
kernel-janitors <kernel-janitors@lists.osdl.org>,
lkml <linux-kernel@vger.kernel.org>,
greg@kroah.com
Subject: Re: [KJ] [RFT 2.6] intel-agp.c: replace pci_find_device with pci_get_device
Date: Wed, 20 Oct 2004 23:10:16 +0100 [thread overview]
Message-ID: <20041020221016.GB12553@redhat.com> (raw)
In-Reply-To: <20041020220638.GA26465@infradead.org>
On Wed, Oct 20, 2004 at 11:06:38PM +0100, Christoph Hellwig wrote:
> > > As pci_find_device is going away soon I have converted this file to use
> > > pci_get_device instead. I have compile tested it. If anyone has this hardware
> > > and could test it that would be great.
> >
> > Should be converted to the pci_driver API.
>
> No. It's already using the pci_driver API, but the same device can be
> handled differently depending on the presence of another one. Maybe
> pci_dev_present would fit here.
Maybe, but if this kind of cleanup work is done on this code,
I want it sat in -mm for quite a while. This code has been
quite fragile in the past, and I've lost count how many
times we've broken some Intel i8xx variant inadvertantly.
The fragility is a good indicator however to just how crap
that code actually is, and was one of my motivations for
moving the EM64T stuff to the -mch driver.
Dave
prev parent reply other threads:[~2004-10-20 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 18:52 Hanna Linder
2004-10-20 22:03 ` [KJ] " Matthew Wilcox
2004-10-20 22:06 ` Christoph Hellwig
2004-10-20 22:10 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020221016.GB12553@redhat.com \
--to=davej@redhat.com \
--cc=davej@codemonkey.org.uk \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®