From: maximilian attems <janitor@sternwelten.at>
To: Hanna Linder <hannal@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org,
greg@kroah.com
Subject: Re: [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 ibmphp_core.c][6/8] replace pci_get_device with pci_dev_present
Date: Thu, 21 Oct 2004 00:57:48 +0200 [thread overview]
Message-ID: <20041020225747.GA1953@stro.at> (raw)
In-Reply-To: <25390000.1096500931@w-hlinder.beaverton.ibm.com>
On Wed, 29 Sep 2004, Hanna Linder wrote:
>
> This can be converted to pci_dev_present as the dev returned is never used.
> Compile tested.
>
> Hanna Linder
> IBM Linux Technology Center
>
> Signed-off-by: Hanna Linder <hannal@us.ibm.com>
>
> diff -Nrup linux-2.6.9-rc2-mm4cln/drivers/pci/hotplug/ibmphp_core.c linux-2.6.9-rc2-mm4patch2/drivers/pci/hotplug/ibmphp_core.c
> --- linux-2.6.9-rc2-mm4cln/drivers/pci/hotplug/ibmphp_core.c 2004-09-28 14:58:50.000000000 -0700
> +++ linux-2.6.9-rc2-mm4patch2/drivers/pci/hotplug/ibmphp_core.c 2004-09-29 15:39:39.385406240 -0700
> @@ -838,8 +838,11 @@ static int set_bus (struct slot * slot_c
> int rc;
> u8 speed;
> u8 cmd = 0x0;
> - struct pci_dev *dev = NULL;
> int retval;
> + static struct pci_device_id ciobx[] = {
> + { PCI_DEVICE(PCI_VENDOR_ID_SERVERWORKS, 0x0101) },
> + { },
> + };
^^^^
white space damaged
>
> debug ("%s - entry slot # %d\n", __FUNCTION__, slot_cur->number);
> if (SET_BUS_STATUS (slot_cur->ctrl) && is_bus_empty (slot_cur)) {
> @@ -886,8 +889,7 @@ static int set_bus (struct slot * slot_c
> break;
> case BUS_SPEED_133:
> /* This is to take care of the bug in CIOBX chip */
> - while ((dev = pci_get_device(PCI_VENDOR_ID_SERVERWORKS,
> - 0x0101, dev)) != NULL)
> + if(pci_dev_present(ciobx))
> ibmphp_hpc_writeslot (slot_cur, HPC_BUS_100PCIXMODE);
> cmd = HPC_BUS_133PCIXMODE;
> break;
>
first timer for your patches.
corrected for next kjt.
--
maks
kernel janitor http://janitor.kernelnewbies.org/
prev parent reply other threads:[~2004-10-20 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 23:35 Hanna Linder
2004-10-20 22:57 ` maximilian attems [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020225747.GA1953@stro.at \
--to=janitor@sternwelten.at \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome