From: Andrew Morton <akpm@osdl.org>
To: blaisorblade_spam@yahoo.it
Cc: agk@redhat.com, neilb@cse.unsw.edu.au,
linux-kernel@vger.kernel.org, blaisorblade_spam@yahoo.it
Subject: Re: [patch 1/1] dm: fix printk errors about whether %lu/%Lu is right for sector_t - revised
Date: Fri, 22 Oct 2004 02:53:40 -0700 [thread overview]
Message-ID: <20041022025340.058837f7.akpm@osdl.org> (raw)
In-Reply-To: <20041021224554.402233F37@zion.localdomain>
blaisorblade_spam@yahoo.it wrote:
>
> The Device Manager code barfs when sector_t is 64bit wide (i.e. an u64) and
> CONFIG_LBD is off. This happens on printk(), resulting in wrong memory
> accesses, but also on sscanf(), resulting in overflows (because it uses %lu
> for a long long in this case). And region_t, chunk_t are typedefs for
> sector_t, so we have warnings for these, too.
This patch caused the x86_64 build to puke: "Not allowed to define
CONFIG_LBD on this architecture" or some such.
I'd much prefer that you simply remove SECTOR_FORMAT completely.
next prev parent reply other threads:[~2004-10-22 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 22:45 blaisorblade_spam
2004-10-22 9:53 ` Andrew Morton [this message]
2004-10-25 20:55 ` BlaisorBlade
2004-10-25 21:46 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2004-10-19 22:46 blaisorblade_spam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022025340.058837f7.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=agk@redhat.com \
--cc=blaisorblade_spam@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®