From: Jan Kara <jack@suse.cz>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, Jan Engelhardt <jengelh@linux01.gwdg.de>
Subject: [PATCH] Quota warnings somewhat broken
Date: Fri, 22 Oct 2004 11:34:23 +0200 [thread overview]
Message-ID: <20041022093423.GC31932@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <Pine.LNX.4.53.0410211807020.12823@yvahk01.tjqt.qr>
Hello,
> When a user exceeds his soft (and hard) disk quota, a warning message is
> printed to current->tty. However, output is a bit offset:
>
> $ dd if=/dev/zero of=blk bs=1024 count=100000
> hda1: write failed, user block limit reached.
> dd: opening `blk': Disk quota exceeded
>
> This is due to the messages in fs/dquot.c only ending in "\n" but should
> probably end in "\r\n".
Thanks for notifying. It looks like a good idea. Attached patch should apply
well to 2.6.9. Linus, please apply.
Honza
Fix end of lines in quota messages.
Signed-off-by: Jan Kara
diff -ru linux-2.6.8.1/fs/dquot.c linux-2.6.8.1-messfix/fs/dquot.c
--- linux-2.6.8.1/fs/dquot.c 2004-10-19 12:07:08.000000000 +0200
+++ linux-2.6.8.1-messfix/fs/dquot.c 2004-10-22 11:28:26.678037906 +0200
@@ -811,22 +811,22 @@
tty_write_message(current->signal->tty, quotatypes[dquot->dq_type]);
switch (warntype) {
case IHARDWARN:
- msg = " file limit reached.\n";
+ msg = " file limit reached.\r\n";
break;
case ISOFTLONGWARN:
- msg = " file quota exceeded too long.\n";
+ msg = " file quota exceeded too long.\r\n";
break;
case ISOFTWARN:
- msg = " file quota exceeded.\n";
+ msg = " file quota exceeded.\r\n";
break;
case BHARDWARN:
- msg = " block limit reached.\n";
+ msg = " block limit reached.\r\n";
break;
case BSOFTLONGWARN:
- msg = " block quota exceeded too long.\n";
+ msg = " block quota exceeded too long.\r\n";
break;
case BSOFTWARN:
- msg = " block quota exceeded.\n";
+ msg = " block quota exceeded.\r\n";
break;
}
tty_write_message(current->signal->tty, msg);
next prev parent reply other threads:[~2004-10-22 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 16:12 Jan Engelhardt
2004-10-22 9:34 ` Jan Kara [this message]
2004-10-22 15:07 ` [PATCH] " Linus Torvalds
2004-10-22 14:25 ` Alan Cox
2004-10-22 17:06 ` [PATCH] " Jan Engelhardt
2004-10-22 23:35 ` Chris Wedgwood
2004-10-25 11:15 ` Jan Kara
2004-10-27 12:29 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022093423.GC31932@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®