From: Ben Dooks <ben-linux@fluff.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Interrupts & total mess
Date: Fri, 22 Oct 2004 12:21:17 +0100 [thread overview]
Message-ID: <20041022112117.GB17957@home.fluff.org> (raw)
In-Reply-To: <1098338878.3941.25.camel@gaston>
On Thu, Oct 21, 2004 at 04:07:58PM +1000, Benjamin Herrenschmidt wrote:
> Ok so my simple project of adding NO_IRQ definitions all over the place
> is turning into a nightmare for various reasons (the probe_irq_* stuff
> beeing one of them, as it currently prevents using -1, so I'm leaning
> toward defining NO_IRQ as beeing INT_MIN, nothing against that ?)
>
> However, while trying to do that in a simple way, that is with a
> #ifndef NO_IRQ
> #define NO_IRQ (INT_MIN)
> #endif
>
> Somewhere in some generic piece of include after we has some asm/* stuff
> included to let the arch a chance to override it, I figured that, first,
> there are a number of places where "irq" is defined as beeing unsigned
> long... So neither INT_MIN nor -1 are appropriate. Then I noticed while
> looking for the right files to add this stuff that we have, at least:
>
> include/linux/interrupts.h
> include/linux/irq.h
> include/linux/hardirq.h
> include/asm-*/irq.h
> include/asm-*/hw_irq.h
> include/asm-*/hardirq.h
also see the drivers/base/platform.c for the definition of
platform_get_irq() which also should be considered for this
(see earlier posting about the return code).
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
prev parent reply other threads:[~2004-10-22 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-21 6:07 Benjamin Herrenschmidt
2004-10-22 11:21 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022112117.GB17957@home.fluff.org \
--to=ben-linux@fluff.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®