From: Stelian Pop <stelian@popies.net>
To: Dominik Brodowski <linux@dominikbrodowski.de>
Cc: jgarzik@pobox.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pcmcia network drivers cleanup
Date: Mon, 25 Oct 2004 17:30:38 +0200 [thread overview]
Message-ID: <20041025153038.GF3161@crusoe.alcove-fr> (raw)
In-Reply-To: <20041025152121.GA7647@dominikbrodowski.de>
[lkml added back in CC: list]
On Mon, Oct 25, 2004 at 05:21:21PM +0200, Dominik Brodowski wrote:
> I'd prefer if the irq_ module parameters weren't defined in one header with
> the nasty INTER_MODULE_PARAM(), but be kept per-module / per-device, i.e.
> the
>
> #define INT_MODULE_PARM(n, v) static int n = v; MODULE_PARM(n, "i")
>
> static int irq_list[4] = { -1 };
> MODULE_PARM(irq_list, "1-4i");
> INT_MODULE_PARM(irq_mask, 0xdeb8);
>
> block being replaced with
>
>
> static int irq_list[4] = { -1 };
> static int irq_mask irq_mask = 0xdeb8;
>
> module_parm(irq_mask, int, 0444};
Sure, it is probably saner, but INT_MODULE_PARM is used for quite a
few other parameters in each driver, and I didn't want to touch
all of them.
Would a patch modifying all occurences of INT_MODULE_PARM be accepted
by whoever maintains those drivers ?
Stelian.
--
Stelian Pop <stelian@popies.net>
next parent reply other threads:[~2004-10-25 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20041025152121.GA7647@dominikbrodowski.de>
2004-10-25 15:30 ` Stelian Pop [this message]
2004-10-25 15:36 ` Dominik Brodowski
2004-10-26 12:03 ` Stelian Pop
2004-10-25 14:15 Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041025153038.GF3161@crusoe.alcove-fr \
--to=stelian@popies.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®