From: Andi Kleen <ak@suse.de>
To: Corey Minyard <minyard@acm.org>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: Race betwen the NMI handler and the RTC clock in practially all kernels
Date: Mon, 25 Oct 2004 22:14:23 +0200 [thread overview]
Message-ID: <20041025201423.GF9142@wotan.suse.de> (raw)
In-Reply-To: <417D5903.6090106@acm.org>
On Mon, Oct 25, 2004 at 02:50:27PM -0500, Corey Minyard wrote:
> According to the comments in 2.4, this code causes the NMI to be
> re-asserted if another NMI occurred while the NMI handler was running.
> I have no idea how twiddling with these CMOS registers causes this to
> happen, but that is supposed to be the intent. I don't think it has
I doubt it does anything useful on anything modern.
> anything to do with delays.
Old chipsets didn't like it when you did two accesses to related
registers in a row. Doing a dummy io inbetween causes an delay
that is long enough that fixes that. I think it was just an old fashioned
way to write out_p(). You need some kind of dummy register for this
and the code used the wrong one.
>
> I would like to know what this code really does before removing it.
It clears and sets the NMI enable bit of the chipset. IMHO it's useless
because no chipset should clear it. If anything you can just unconditionally
reenable it.
-Andi
next prev parent reply other threads:[~2004-10-25 21:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <417D2305.3020209@acm.org.suse.lists.linux.kernel>
2004-10-25 19:44 ` Andi Kleen
2004-10-25 19:50 ` Corey Minyard
2004-10-25 20:14 ` Andi Kleen [this message]
2004-10-25 20:15 ` linux-os
2004-10-25 20:07 ` Maciej W. Rozycki
2004-10-25 20:17 ` Andi Kleen
2004-10-25 20:41 ` Race betwen the NMI handler and the RTC clock in practially all kernels II Andi Kleen
2004-10-25 21:00 ` Maciej W. Rozycki
2004-10-25 22:04 ` Corey Minyard
2004-10-25 23:40 ` Maciej W. Rozycki
2004-10-26 2:50 ` Corey Minyard
2004-10-26 12:01 ` linux-os
2004-10-25 20:47 ` Race betwen the NMI handler and the RTC clock in practially all kernels Maciej W. Rozycki
2004-10-25 20:11 ` linux-os
2004-10-25 20:23 ` Andi Kleen
2004-10-25 16:00 Corey Minyard
2004-10-26 13:56 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041025201423.GF9142@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®