mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mark_H_Johnson@raytheon.com
Cc: Alexander Batyrshin <abatyrshin@ru.mvista.com>,
	Bill Huey <bhuey@lnxw.com>, Adam Heath <doogie@debian.org>,
	"K.R. Foley" <kr@cybsft.com>,
	linux-kernel@vger.kernel.org,
	Florian Schmidt <mista.tapas@gmx.net>,
	Fernando Pablo Lopez-Lezcano <nando@ccrma.Stanford.EDU>,
	Lee Revell <rlrevell@joe-job.com>,
	Rui Nuno Capela <rncbc@rncbc.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Michal Schmidt <xschmi00@stud.feec.vutbr.cz>
Subject: Re: [patch] Real-Time Preemption, -RT-2.6.9-mm1-V0
Date: Mon, 25 Oct 2004 23:01:35 +0200	[thread overview]
Message-ID: <20041025210135.GA28699@elte.hu> (raw)
In-Reply-To: <OF1ADC83B8.7696CB2F-ON86256F38.0066D6EA@raytheon.com>


* Mark_H_Johnson@raytheon.com <Mark_H_Johnson@raytheon.com> wrote:

> BUG: sleeping function called from invalid context hdparm(3606) at
> kernel/mutex.c
> in_atomic():0 [00000000], irqs_disabled():1
> ... will send stack traceback separately ...
> when setting udma2 mode in hdparm.

i suspect the patch below will fix the hdparm message - but i dont think
it's related to the other problems you have reported. 

	Ingo

--- linux/drivers/ide/ide-iops.c.orig
+++ linux/drivers/ide/ide-iops.c
@@ -783,13 +783,11 @@ int ide_driveid_update (ide_drive_t *dri
 		printk("%s: CHECK for good STATUS\n", drive->name);
 		return 0;
 	}
-	local_irq_save(flags);
-	SELECT_MASK(drive, 0);
 	id = kmalloc(SECTOR_WORDS*4, GFP_ATOMIC);
-	if (!id) {
-		local_irq_restore(flags);
+	if (!id)
 		return 0;
-	}
+	local_irq_save(flags);
+	SELECT_MASK(drive, 0);
 	ata_input_data(drive, id, SECTOR_WORDS);
 	(void) hwif->INB(IDE_STATUS_REG);	/* clear drive IRQ */
 	local_irq_enable();

  reply	other threads:[~2004-10-25 21:20 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-25 18:55 Mark_H_Johnson
2004-10-25 21:01 ` Ingo Molnar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-10-25 15:42 Mark_H_Johnson
2004-10-15 10:26 [patch] Real-Time Preemption, -VP-2.6.9-rc4-mm1-U3 Ingo Molnar
2004-10-16 15:33 ` [patch] Real-Time Preemption, -VP-2.6.9-rc4-mm1-U4 Ingo Molnar
2004-10-18 14:50   ` [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U5 Ingo Molnar
2004-10-19 12:46     ` [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U6 Ingo Molnar
2004-10-19 18:00       ` [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U7 Ingo Molnar
2004-10-20  9:45         ` [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U8 Ingo Molnar
2004-10-21 13:27           ` [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U9 Ingo Molnar
2004-10-22 13:35             ` [patch] Real-Time Preemption, -RT-2.6.9-rc4-mm1-U9.3 Ingo Molnar
2004-10-22 15:50               ` [patch] Real-Time Preemption, -RT-2.6.9-mm1-U10 Ingo Molnar
2004-10-22 17:56                 ` [patch] Real-Time Preemption, -RT-2.6.9-mm1-U10.2 Ingo Molnar
2004-10-25 10:40                   ` [patch] Real-Time Preemption, -RT-2.6.9-mm1-V0 Ingo Molnar
2004-10-25 11:08                     ` K.R. Foley
2004-10-25 11:10                       ` Ingo Molnar
2004-10-25 11:13                         ` K.R. Foley
2004-10-25 12:12                         ` Ingo Molnar
2004-10-25 13:24                           ` Florian Schmidt
2004-10-25 13:26                             ` Ingo Molnar
2004-10-25 14:03                               ` Florian Schmidt
2004-10-25 14:10                                 ` Ingo Molnar
2004-10-25 14:16                                   ` Ingo Molnar
2004-10-25 19:40                                     ` Rui Nuno Capela
2004-10-26  3:01                                       ` Lee Revell
2004-10-26  3:11                                         ` K.R. Foley
2004-10-26  3:58                                           ` Lee Revell
2004-10-26  4:15                                             ` K.R. Foley
2004-10-26  5:11                                         ` Fernando Pablo Lopez-Lezcano
2004-10-26 17:25                                           ` Lee Revell
2004-10-26 17:45                                             ` Fernando Pablo Lopez-Lezcano
2004-10-26 17:55                                               ` Lee Revell
2004-10-26  5:28                                       ` Denis Vlasenko
2004-10-26 10:40                                         ` Rui Nuno Capela
2004-10-26 19:09                                           ` Denis Vlasenko
2004-10-27  8:23                                             ` Rui Nuno Capela
2004-10-25 15:06                                   ` Florian Schmidt
2004-10-25 16:45                                     ` K.R. Foley
2004-10-26  8:29                                       ` Eran Mann
2004-10-25 13:39                           ` Florian Schmidt
2004-10-25 13:48                             ` Florian Schmidt
2004-10-25 13:35                               ` Ingo Molnar
2004-10-25 18:52                     ` K.R. Foley
2004-10-25 20:38                       ` Ingo Molnar
2004-10-26 10:53                         ` K.R. Foley
2004-10-26 10:57                           ` Ingo Molnar
2004-10-27  0:24                           ` Ingo Molnar
2004-10-27  0:53                             ` K.R. Foley
2004-10-27  3:32                             ` K.R. Foley
2004-10-27  8:28                               ` Ingo Molnar
2004-10-27  8:44                                 ` Ingo Molnar
2004-10-27  8:52                                   ` Ingo Molnar
2004-10-27  9:06                                     ` Ingo Molnar
2004-10-27 10:03                                       ` Ingo Molnar
2004-10-27 10:33                                       ` Florian Schmidt
2004-10-27 10:29                                         ` Ingo Molnar
2004-10-27 10:58                                           ` Florian Schmidt
2004-10-27 10:45                                         ` Florian Schmidt
2004-10-27 11:09                                           ` Ingo Molnar
2004-10-27  9:24                               ` Ingo Molnar
2004-10-27  9:32                                 ` Ingo Molnar
2004-10-27 12:19                                   ` K.R. Foley
2004-10-27 13:29                               ` Ingo Molnar
2004-10-27 15:00                                 ` K.R. Foley
2004-10-27 15:05                                   ` Ingo Molnar
2004-10-27 15:13                                     ` Lee Revell
2004-10-27 15:17                                       ` Ingo Molnar
2004-10-27 17:14                                         ` Lee Revell
2004-10-27 17:21                                           ` K.R. Foley
2004-10-27 17:26                                             ` Lee Revell
2004-10-27 17:40                                               ` K.R. Foley
2004-10-27 17:44                                                 ` Lee Revell
2004-10-27 17:43                                               ` K.R. Foley
2004-10-27 19:47                                                 ` Lee Revell
2004-10-27 21:40                                                   ` K.R. Foley
2004-10-27 20:09                                         ` Andrew Morton
2004-10-27 21:43                                           ` K.R. Foley
2004-10-27 15:16                                     ` K.R. Foley
2004-10-27 20:49                                     ` Bill Huey
2004-10-27 20:54                                       ` Bill Huey
2004-10-27 21:01                                         ` Bill Huey
2004-10-28  7:11                                           ` Ingo Molnar
2004-10-27  3:48                             ` K.R. Foley
2004-10-25 21:41                       ` Esben Nielsen
2004-10-25 21:47                     ` Michal Schmidt
2004-10-25 23:04                     ` Remi Colinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041025210135.GA28699@elte.hu \
    --to=mingo@elte.hu \
    --cc=Mark_H_Johnson@raytheon.com \
    --cc=abatyrshin@ru.mvista.com \
    --cc=bhuey@lnxw.com \
    --cc=doogie@debian.org \
    --cc=kr@cybsft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mista.tapas@gmx.net \
    --cc=nando@ccrma.Stanford.EDU \
    --cc=rlrevell@joe-job.com \
    --cc=rncbc@rncbc.org \
    --cc=tglx@linutronix.de \
    --cc=xschmi00@stud.feec.vutbr.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome