From: Andrew Morton <akpm@osdl.org>
To: jfannin1@columbus.rr.com
Cc: agk@redhat.com, matt@minas-morgul.org, jfannin1@columbus.rr.com,
christophe@saout.de, linux-kernel@vger.kernel.org, axboe@suse.de,
bzolnier@gmail.com
Subject: Re: 2.6.9-mm1: LVM stopped working (dio-handle-eof.patch)
Date: Tue, 26 Oct 2004 15:15:59 -0700 [thread overview]
Message-ID: <20041026151559.041088f1.akpm@osdl.org> (raw)
In-Reply-To: <20041026213703.GA6174@rivenstone.net>
jfannin1@columbus.rr.com wrote:
>
> > [To check for repeat of old problems with related symptoms:]
> > Were both kernels compiled with the same compiler version? Which version?
> > Does it make any difference if you rebuild lvm with --disable-o_direct?
>
> Chris Han (BCC'ed) mailed me to let me know he'd narrowed the
> problem down to the 'dio-handle-eof.patch'. Reverting it makes things
> work for me too. Yay!
If you have time, please restore dio-handle-eof.patch and then apply the
below fixup, then retest. Thanks.
--- 25/fs/direct-io.c~dio-handle-eof-fix 2004-10-26 00:49:40.363376432 -0700
+++ 25-akpm/fs/direct-io.c 2004-10-26 00:49:40.367375824 -0700
@@ -987,6 +987,8 @@ direct_io_worker(int rw, struct kiocb *i
isize = i_size_read(inode);
if (bytes_todo > (isize - offset))
bytes_todo = isize - offset;
+ if (!bytes_todo)
+ return 0;
for (seg = 0; seg < nr_segs && bytes_todo; seg++) {
user_addr = (unsigned long)iov[seg].iov_base;
_
next prev parent reply other threads:[~2004-10-26 22:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-23 23:06 2.6.9-mm1: LVM stopped working Mathieu Segaud
2004-10-25 19:03 ` Christophe Saout
2004-10-25 22:31 ` Mathieu Segaud
2004-10-26 11:00 ` Mathieu Segaud
2004-10-26 12:36 ` jfannin1
2004-10-26 13:55 ` Jeff Chua
2004-10-26 14:09 ` Alasdair G Kergon
2004-10-26 13:59 ` Alasdair G Kergon
2004-10-26 21:37 ` 2.6.9-mm1: LVM stopped working (dio-handle-eof.patch) jfannin1
2004-10-26 22:15 ` Andrew Morton [this message]
2004-10-27 4:36 ` Mathieu Segaud
2004-10-27 5:26 ` Andrew Morton
2004-10-27 5:47 ` Jens Axboe
2004-10-27 6:41 ` Jens Axboe
2004-10-27 15:03 ` Joseph Fannin
2004-10-27 15:29 ` Alasdair G Kergon
2004-10-27 15:36 ` Mathieu Segaud
2004-10-27 20:24 ` Andrew Morton
2004-10-27 20:37 ` Mathieu Segaud
2004-10-28 4:52 ` Jeff Chua
2004-10-28 14:56 ` Alasdair G Kergon
2004-10-29 4:58 ` Jeff Chua
2004-10-29 5:31 ` Bernd Eckenfels
2004-10-28 15:49 ` Valdis.Kletnieks
2004-11-02 14:39 ` Jens Axboe
2004-11-02 14:55 ` Jens Axboe
2004-11-02 15:03 ` Mathieu Segaud
2004-11-02 17:03 ` Mathieu Segaud
2004-11-05 6:49 ` Valdis.Kletnieks
2004-10-27 15:42 ` Alasdair G Kergon
2004-10-27 18:13 ` Jeff Chua
2004-10-26 14:00 ` 2.6.9-mm1: LVM stopped working Bartlomiej Zolnierkiewicz
2004-10-26 17:07 ` Bartlomiej Zolnierkiewicz
2004-10-26 17:21 ` Mathieu Segaud
2004-10-26 17:54 ` Mathieu Segaud
2004-10-26 18:04 ` Mathieu Segaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041026151559.041088f1.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=agk@redhat.com \
--cc=axboe@suse.de \
--cc=bzolnier@gmail.com \
--cc=christophe@saout.de \
--cc=jfannin1@columbus.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@minas-morgul.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®