From: "David S. Miller" <davem@davemloft.net>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: Input: sunkbd concern
Date: Tue, 26 Oct 2004 18:06:22 -0700 [thread overview]
Message-ID: <20041026180622.14fc6268.davem@davemloft.net> (raw)
In-Reply-To: <200410221833.04057.dtor_core@ameritech.net>
On Fri, 22 Oct 2004 18:33:04 -0500
Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> I have been looking at sunkbd.c and it seems that it attaches not only to
> ports that speak SUNKBD protocol but also to ports that do not specify any
> protocol:
>
> if ((serio->type & SERIO_PROTO) && (serio->type & SERIO_PROTO) != SERIO_SUNKBD)
> return;
>
> Was that an oversight or it was done intentionally?
I believe it is intentional.
If SERIO_PROTO bits are all clear, this is supposed to have
a special meaning in that any keyboard driver can claim
the serio line.
So if it's the "wildcard" zero value, or specifically SERIO_SUNKBD,
we'll attach to it.
next prev parent reply other threads:[~2004-10-27 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 23:33 Dmitry Torokhov
2004-10-27 1:06 ` David S. Miller [this message]
2004-10-27 1:32 ` Dmitry Torokhov
2004-10-27 5:47 ` Vojtech Pavlik
2004-10-27 6:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041026180622.14fc6268.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome