From: Sam Ravnborg <sam@ravnborg.org>
To: David Vrabel <dvrabel@arcom.com>,
Linus Torvalds <torvalds@osdl.org>,
Len Brown <len.brown@intel.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Versioning of tree
Date: Tue, 26 Oct 2004 21:08:15 +0200 [thread overview]
Message-ID: <20041026190815.GA8338@mars.ravnborg.org> (raw)
In-Reply-To: <20041026122632.GH10638@michonline.com>
On Tue, Oct 26, 2004 at 08:26:33AM -0400, Ryan Anderson wrote:
> On Tue, Oct 26, 2004 at 12:49:02PM +0100, David Vrabel wrote:
> > Ryan Anderson wrote:
> > >
> > >Well, here's a patch that adds -BKxxxxxxxx to LOCALVERSION when a
> > >top-level BitKeeper tree is detected.
> > >[...]
> > > LOCALVERSION = $(subst $(space),, \
> > > $(shell cat /dev/null $(localversion-files)) \
> > >+ $(subst ",,$(localversion-bk)) \
> >
> > Surely there's no need for this? Can't the script spit out an
> > appropriate localversion* file instead?
>
> It can, and yes, my first version used that method.
>
> Except it never worked. I was able to generate the file before
> include/linux/version.h was rebuilt, but failed to get it picked up in
> that. I'm not really sure why.
The $(wildcard ...) function was executed before you created the file.
If we shall retreive the version from a SCM then as you already do
must hide it in a script.
I want the script only to be executed when we actually ask kbuild to
build a kernel - so it has to be part of the prepare rule set.
Furthermore I like to avoid a dependency on perl for a basic kernel.
Can you retreive the version from bk using a simple shell script?
Sam
next prev parent reply other threads:[~2004-10-26 17:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 6:49 Benjamin Herrenschmidt
2004-10-20 7:22 ` Len Brown
2004-10-20 14:33 ` Linus Torvalds
2004-10-21 1:38 ` Benjamin Herrenschmidt
2004-10-21 15:33 ` Måns Rullgård
2004-10-21 15:48 ` Linus Torvalds
2004-10-21 16:49 ` Jeff Garzik
2004-10-21 17:10 ` Linus Torvalds
2004-10-21 23:03 ` kbuild (was Re: Versioning of tree) Jeff Garzik
2004-10-30 23:34 ` Sam Ravnborg
2004-10-25 23:47 ` Versioning of tree Ryan Anderson
2004-10-26 11:49 ` David Vrabel
2004-10-26 12:26 ` Ryan Anderson
2004-10-26 12:58 ` David Vrabel
2004-10-26 19:08 ` Sam Ravnborg [this message]
2004-10-26 18:04 ` Ryan Anderson
2004-10-26 19:11 ` Ian Campbell
2004-10-27 8:38 ` Ryan Anderson
2004-10-27 11:37 ` Sam Ravnborg
2004-10-20 8:22 ` Jeff Garzik
2004-10-20 8:39 ` Benjamin Herrenschmidt
2004-10-20 10:36 ` Måns Rullgård
2004-10-20 18:27 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041026190815.GA8338@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=benh@kernel.crashing.org \
--cc=dvrabel@arcom.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome