mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.de>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Problem with module parameters and sysfs
Date: Wed, 27 Oct 2004 10:58:42 +0200	[thread overview]
Message-ID: <20041027085842.GA7510@dominikbrodowski.de> (raw)
In-Reply-To: <200410270143.54852.dtor_core@ameritech.net>

On Wed, Oct 27, 2004 at 01:43:54AM -0500, Dmitry Torokhov wrote:
> Hi,
> 
> It seems that the following patch
> 
> http://linux.bkbits.net:8080/linux-2.5/diffs/kernel/params.c%401.12?nav=index.html|ChangeSet@-3d|cset@1.2142
> 
> broke module parameters in sysfs for the case when driver is built
> as a module:
> 
> [root@core dtor]# ls -la /sys/module/i8042/
> total 0
> drwxr-xr-x    3 root     root            0 Oct 26 19:20 .
> drwxr-xr-x   54 root     root            0 Oct 27 00:28 ..
> drwxr-xr-x    2 root     root            0 Oct 26 19:20 parameters
> 
> [root@core dtor]# ls -la /sys/module/psmouse/
> total 0
> drwxr-xr-x    3 root     root            0 Oct 27 00:21 .
> drwxr-xr-x   54 root     root            0 Oct 27 00:28 ..
> -r--r--r--    1 root     root         4096 Oct 27 00:21 refcnt
> drwxr-xr-x    2 root     root            0 Oct 27 00:21 sections
> 
> psmouse is built as a module while i8042 is compiled in.

All module_params I can see in psmouse have permission "0", so they don't
need to be exported in sysfs. Or am I missing something here?

Thanks,
	Dominik

  reply	other threads:[~2004-10-27  9:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27  6:43 Dmitry Torokhov
2004-10-27  8:58 ` Dominik Brodowski [this message]
2004-10-27 13:27   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041027085842.GA7510@dominikbrodowski.de \
    --to=linux@dominikbrodowski.de \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome