From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Christoph Lameter'" <clameter@sgi.com>
Cc: "William Lee Irwin III" <wli@holomorphy.com>,
<linux-kernel@vger.kernel.org>
Subject: RE: Hugepages demand paging V1 [4/4]: Numa patch
Date: Wed, 27 Oct 2004 13:53:16 -0700 [thread overview]
Message-ID: <200410272050.i9RKoSq03358@unix-os.sc.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0410271056130.18052@schroedinger.engr.sgi.com>
On Mon, 25 Oct 2004, Chen, Kenneth W wrote:
> > @@ -32,14 +32,17 @@
> > + struct zonelist *zonelist = NODE_DATA(nid)->node_zonelists;
> > + struct zone **zones = zonelist->zones;
> > + struct zone *z;
> > + int i;
> > +
> > + for(i=0; (z = zones[i])!= NULL; i++) {
> > + nid = z->zone_pgdat->node_id;
> > + if (list_empty(&hugepage_freelists[node_id]))
> > + break;
> > }
>
> Also this is generic code, we should consider scanning ZONE_HIGHMEM
> zonelist. Otherwise, this will likely screw up x86 numa machine.
Christoph Lameter wrote on Wednesday, October 27, 2004 10:57 AM
> The highmem zones are included in the zones[] array AFAIK.
node_zonelists is an array in the struct pglist_data. In your patch,
you are referencing the first element in that array, which has a zone
list for all node memory in normal zone.
What will happen for a x86 numa box with highmem only on some nodes?
- Ken
next prev parent reply other threads:[~2004-10-27 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <B05667366EE6204181EABE9C1B1C0EB504BFA479@scsmsx401.amr.corp.intel.com>
2004-10-27 17:57 ` Christoph Lameter
2004-10-27 20:53 ` Chen, Kenneth W [this message]
[not found] <B05667366EE6204181EABE9C1B1C0EB501F2ADFB@scsmsx401.amr.corp.intel.com>
2004-10-22 4:55 ` Hugepages demand paging V1 [0/4]: Discussion and overview Christoph Lameter
2004-10-22 4:58 ` Hugepages demand paging V1 [4/4]: Numa patch Christoph Lameter
2004-10-22 6:05 ` Chen, Kenneth W
2004-10-22 11:00 ` William Lee Irwin III
2004-10-22 19:37 ` Christoph Lameter
2004-10-22 19:40 ` William Lee Irwin III
2004-10-25 21:25 ` Chen, Kenneth W
2004-10-25 21:52 ` William Lee Irwin III
2004-10-25 21:55 ` William Lee Irwin III
2004-10-25 21:05 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410272050.i9RKoSq03358@unix-os.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome