Re: [patch 7/7] uml: resolve symbols in back-traces

[Blaisorblade <blaisorblade_spam@yahoo.it>]

On Thursday 28 October 2004 21:28, Chris Wedgwood wrote:
> On Thu, Oct 28, 2004 at 08:34:21PM +0200, Blaisorblade wrote:
> > And removing the final Emacs comment is not welcome (I don't care,
> > but Jeff does. If that should be removed, that's a separate
> > problem).

> the emacs comments are gratuitous and completely pointless, they serve
> no useful purpose.  fwiw in my .emacs i have:

>     (defun cw-linux-c-mode ()
>       "C mode with adjusted defaults for use with the Linux kernel."
>       (interactive)
>       (c-mode)
>       (c-set-style "linux"))
>     (setq auto-mode-alist
>    (append '(("wk/linux.*/.*\\.[ch]$" . cw-linux-c-mode))
>     '(("/usr/src/linux.*/.*\\.[ch]$" . cw-linux-c-mode))
>     auto-mode-alist))
>
> which actually could be cleaned up a bit (it's been hacked over the
> years and never cleaned up suitably) but the idea is pretty simple

I mostly agree on this, and thought it myself (I *never* use Emacs, only Vim, 
but no flames here).

However, let's be kind with Jeff, since he's the UML maintainer. You can be 
right, but there's also courtesy.

If Jeff says "OK", then someone can submit a separate patch removing all the 
final comments.

Until then, please don't.

And never mix such unrelated changes in a patch.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729