mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Chris Wright <chrisw@osdl.org>,
	bunk@stusta.de, reiser@namesys.com, linux-kernel@vger.kernel.org
Subject: Re: 2.6.10-rc1-mm2: `key_init' multiple definition
Date: Fri, 29 Oct 2004 13:36:31 -0700	[thread overview]
Message-ID: <20041029133631.Q2357@build.pdx.osdl.net> (raw)
In-Reply-To: <20041029132016.272c30b2.akpm@osdl.org>; from akpm@osdl.org on Fri, Oct 29, 2004 at 01:20:16PM -0700

* Andrew Morton (akpm@osdl.org) wrote:
> Chris Wright <chrisw@osdl.org> wrote:
> > I don't think this is needed.  The fix in Linus's tree should be
> > sufficient, which was simply:
> > 
> > -subsys_initcall(key_init);
> > +security_initcall(key_init);
> 
> Problem is with CONFIG_SECURITY=n, CONFIG_KEYS=y.  security_init() is a
> no-op and we go oops during the first usermodehelper call under
> driver_init().

Hmm, right.  Is it worth changing that?  Or do you prefer the explicit
approach you have?  init ordering is still messy, no matter how we slice
it.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2004-10-29 20:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-29  8:49 2.6.10-rc1-mm2 Andrew Morton
2004-10-29 10:24 ` 2.6.10-rc1-mm2 (compiler warnings on x86_64) Rafael J. Wysocki
2004-10-29 11:45 ` 2.6.10-rc1-mm2: `key_init' multiple definition Adrian Bunk
2004-10-29 17:35   ` Chris Wright
2004-10-29 20:20     ` Andrew Morton
2004-10-29 20:36       ` Chris Wright [this message]
2004-10-29 23:52         ` Andrew Morton
2004-10-29 23:53           ` Chris Wright
2004-10-29 16:04 ` 2.6.10-rc1-mm2 Alexander Nyberg
2004-10-29 17:44   ` 2.6.10-rc1-mm2 Randy.Dunlap
2004-10-29 17:16 ` 2.6.10-rc1-mm2 Borislav Petkov
2004-10-29 19:55 ` 2.6.10-rc1-mm2 Doug Maxey
2004-10-29 22:13   ` 2.6.10-rc1-mm2 Sam Ravnborg
2004-10-29 21:24     ` 2.6.10-rc1-mm2 Doug Maxey
2004-10-29 22:33 ` 2.6.10-rc1-mm2 (badness) Randy.Dunlap
2004-10-30  3:24 ` 2.6.10-rc1-mm2: intelfb/AGP unknown symbols Adrian Bunk
2004-10-30  8:28   ` Arjan van de Ven
2004-10-30 11:21     ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-10-30 11:34       ` Arjan van de Ven
2004-10-30 13:08         ` Antonino A. Daplas
2004-10-30 15:16     ` Christoph Hellwig
2004-10-30 15:18 ` No PS2 with ACPI [was Re: 2.6.10-rc1-mm2] J.A. Magallon
2004-10-30 21:31   ` Andrew Morton
2004-10-31  0:06     ` Dmitry Torokhov
2004-11-01 22:05       ` J.A. Magallon
2004-11-02  3:31         ` Dmitry Torokhov
2004-11-01  8:46   ` Amit Shah
2004-11-03  6:08 ` ipw2100 and 2.6.10-rc1-bk12 Marcos D. Marado Torres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041029133631.Q2357@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiser@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome