From: Chris Wright <chrisw@osdl.org>
To: ak@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] remove duplicate FAKE_STACK_FRAME macro
Date: Fri, 29 Oct 2004 16:14:56 -0700 [thread overview]
Message-ID: <20041029161456.S2357@build.pdx.osdl.net> (raw)
Hi Andi,
FAKE_STACK_FRAME macro is defined twice. The one that gets used is in
arch/x86_64/kernel/entry.S, and is slightly different codewise, although
should have the same end result (uses pushq rather than addq %rsp + movq
and has the extra dwarf annotations). Looks like we can remove the dups?
Signed-off-by: Chris Wright <chrisw@osdl.org>
===== include/asm-x86_64/calling.h 1.10 vs edited =====
--- 1.10/include/asm-x86_64/calling.h 2004-03-21 12:35:48 -08:00
+++ edited/include/asm-x86_64/calling.h 2004-10-28 17:00:53 -07:00
@@ -143,22 +143,6 @@
RESTORE_ARGS 0,\addskip
.endm
- /* push in order ss, rsp, eflags, cs, rip */
- .macro FAKE_STACK_FRAME child_rip
- xorl %eax,%eax
- subq $6*8,%rsp
- movq %rax,5*8(%rsp) /* ss */
- movq %rax,4*8(%rsp) /* rsp */
- movq $(1<<9),3*8(%rsp) /* eflags */
- movq $__KERNEL_CS,2*8(%rsp) /* cs */
- movq \child_rip,1*8(%rsp) /* rip */
- movq %rax,(%rsp) /* orig_rax */
- .endm
-
- .macro UNFAKE_STACK_FRAME
- addq $8*6, %rsp
- .endm
-
.macro icebp
.byte 0xf1
.endm
next reply other threads:[~2004-10-29 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 23:14 Chris Wright [this message]
2004-10-29 23:37 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041029161456.S2357@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®