From: Matthew Wilcox <matthew@wil.cx>
To: Linus Torvalds <torvalds@osdl.org>
Cc: parisc-linux@parisc-linux.org, linux-kernel@vger.kernel.org
Subject: [PATCH] stifb bugfixes against 2.6.10-rc1-bk9
Date: Sat, 30 Oct 2004 21:41:44 +0100 [thread overview]
Message-ID: <20041030204144.GK8958@parcelfarce.linux.theplanet.co.uk> (raw)
- Fix "sti= parameter ignored by stifb" bug (Stuart Brady)
- Fix the STI crash with HCRX-24 in 32bpp mode (Helge Deller)
diff -urpNX dontdiff linux-2.6.10-rc1-bk9/drivers/video/stifb.c parisc-2.6-bk/drivers/video/stifb.c
--- linux-2.6.10-rc1-bk9/drivers/video/stifb.c Fri Oct 22 15:40:35 2004
+++ parisc-2.6-bk/drivers/video/stifb.c Sat Oct 30 09:31:49 2004
@@ -112,6 +112,7 @@ struct stifb_info {
ngle_rom_t ngle_rom;
struct sti_struct *sti;
int deviceSpecificConfig;
+ u32 pseudo_palette[16];
};
static int __initdata bpp = 8; /* parameter from modprobe */
@@ -1030,6 +1031,14 @@ stifb_setcolreg(u_int regno, u_int red,
/* 0x100 is same as used in WRITE_IMAGE_COLOR() */
START_COLORMAPLOAD(fb, lutBltCtl.all);
SETUP_FB(fb);
+
+ /* info->var.bits_per_pixel == 32 */
+ if (regno < 16)
+ ((u32 *)(info->pseudo_palette))[regno] =
+ (red << info->var.red.offset) |
+ (green << info->var.green.offset) |
+ (blue << info->var.blue.offset);
+
} else {
/* cleanup colormap hardware */
FINISH_IMAGE_COLORMAP_ACCESS(fb);
@@ -1327,6 +1336,7 @@ stifb_init_fb(struct sti_struct *sti, in
info->screen_base = (void*) REGION_BASE(fb,1);
info->flags = FBINFO_DEFAULT;
info->currcon = -1;
+ info->pseudo_palette = &fb->pseudo_palette;
/* This has to been done !!! */
fb_alloc_cmap(&info->cmap, 256, 0);
@@ -1383,6 +1393,7 @@ int __init
stifb_init(void)
{
struct sti_struct *sti;
+ struct sti_struct *def_sti;
int i;
#ifndef MODULE
@@ -1397,9 +1408,19 @@ stifb_init(void)
return -ENXIO;
}
+ def_sti = sti_get_rom(0);
+ if (def_sti) {
+ for (i = 1; i < MAX_STI_ROMS; i++) {
+ sti = sti_get_rom(i);
+ if (sti == def_sti && bpp > 0)
+ stifb_force_bpp[i] = bpp;
+ }
+ stifb_init_fb(def_sti, stifb_force_bpp[i]);
+ }
+
for (i = 1; i < MAX_STI_ROMS; i++) {
sti = sti_get_rom(i);
- if (!sti)
+ if (!sti || sti==def_sti)
break;
if (bpp > 0)
stifb_force_bpp[i] = bpp;
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
reply other threads:[~2004-10-30 20:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041030204144.GK8958@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=parisc-linux@parisc-linux.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®