From: Andi Kleen <ak@suse.de>
To: Chris Wedgwood <cw@f00f.org>
Cc: Andi Kleen <ak@suse.de>, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add panic blinking to 2.6
Date: Sun, 31 Oct 2004 03:54:18 +0100 [thread overview]
Message-ID: <20041031025418.GH19396@wotan.suse.de> (raw)
In-Reply-To: <20041031022537.GB18294@taniwha.stupidest.org>
On Sat, Oct 30, 2004 at 07:25:37PM -0700, Chris Wedgwood wrote:
> > +static int blink_frequency = 500;
> > +module_param_named(panicblink, blink_frequency, int, 0600);
>
> does it reall need to be a module?
It isn't a module.
>
> > +/* Returns how long it waited in ms */
> > +long (*panic_blink)(long time) = no_blink;
> > +EXPORT_SYMBOL(panic_blink);
>
> i dont know we can't have this unconditionally with the 500ms period
> (always present and on)
>
> would that really harm anything?
Yes, one broken KVM seems to block switching with it in some cases
-Andi
prev parent reply other threads:[~2004-10-31 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-31 1:36 Andi Kleen
2004-10-31 2:25 ` Chris Wedgwood
2004-10-31 2:54 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041031025418.GH19396@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=cw@f00f.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®