From: Pavel Machek <pavel@ucw.cz>
To: Stelian Pop <stelian@popies.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH 4/8] sonypi: rework input support
Date: Sun, 31 Oct 2004 12:30:15 +0100 [thread overview]
Message-ID: <20041031113015.GA1044@elf.ucw.cz> (raw)
In-Reply-To: <20041029104138.GA3222@crusoe.alcove-fr>
Hi!
> > > + { SONYPI_EVENT_FNKEY_F1, KEY_FN_F1 },
> > > + { SONYPI_EVENT_FNKEY_F2, KEY_FN_F2 },
> > > + { SONYPI_EVENT_FNKEY_F3, KEY_FN_F3 },
> [...]
>
> > KEY_FN_D does not sound too usefull (similar for FN_F1..FN_F12). Are
> > there some pictures on those keys?
>
> Some of them have pictures (Fn-Esc for suspend to ram, Fn-F12 for
> suspend to disk, Fn-F3 for mute, Fn-F4 for launching the volume
> controls, Fn-F5 for launching the brightness controls, Fn-F7/F8 for
> changing from LCD to external monitor or TV). All the others have
> no pictures on them.
In such case I'd assign meaningfull events at least to keys with
labels?
> > Mapping FN_F3 to for example
> > KEY_SUSPEND would be usefull...
>
> This sound like policy to me and should not be done into the
> kernel but somewhere you can configure it, like in a keyboard
> keymap or something like that.
Eh? You are basically doing arbitrary mapping between sony events to
linux keycodes. You might as well make the mapping usefull while you
are at it.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next prev parent reply other threads:[~2004-10-31 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-28 10:05 [PATCH 0/8] sonypi driver update Stelian Pop
2004-10-28 10:06 ` [PATCH 1/8] sonypi: module related fixes Stelian Pop
2004-10-28 10:07 ` [PATCH 2/8] sonypi: replace homebrew queue with kfifo Stelian Pop
2004-10-28 10:07 ` [PATCH 3/8] sonypi: power management related fixes Stelian Pop
2004-10-28 10:08 ` [PATCH 4/8] sonypi: rework input support Stelian Pop
2004-10-29 10:10 ` Pavel Machek
2004-10-29 10:41 ` Stelian Pop
2004-10-31 11:30 ` Pavel Machek [this message]
2004-10-28 10:08 ` [PATCH 5/8] sonypi: make CONFIG_SONYPI depend on CONFIG_INPUT Stelian Pop
2004-10-28 10:09 ` [PATCH 6/8] sonypi: don't suppose the bluetooth subsystem is initialy off Stelian Pop
2004-10-28 10:09 ` [PATCH 7/8] sonypi: whitespace and coding style fixes Stelian Pop
2004-10-28 10:10 ` [PATCH 8/8] sonypi: bump up the version number Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041031113015.GA1044@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stelian@popies.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome