mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Fabio Coatti <cova@ferrara.linux.it>
Cc: Paulo da Silva <psdasilva@esoterica.pt>,
	linux-kernel@vger.kernel.org, zaitcev@redhat.com
Subject: Re: k 2.6.9: ub module causes /dev/sda and /dev/sda1 not being created
Date: Sun, 31 Oct 2004 14:57:20 -0800	[thread overview]
Message-ID: <20041031145720.448d2ee9@lembas.zaitcev.lan> (raw)
In-Reply-To: <200410312310.43557.cova@ferrara.linux.it>

On Sun, 31 Oct 2004 23:10:43 +0100, Fabio Coatti <cova@ferrara.linux.it> wrote:

> Maybe this is not a problem, but it's supposed that a /dev/uba1 is created, 
> after /dev/uba, instead of sdaX? well, on my system uba is created but 
> not /dev/uba1, and I've reported below a syslog excerpt for usb flash 
> pendrive;
>[...]
> Oct 28 00:32:22 kefk kernel: uba: device 4 capacity nsec 50 bsize 512
> Oct 28 00:32:22 kefk kernel: uba: made changed
> Oct 28 00:32:22 kefk kernel: uba: device 4 capacity nsec 1024000 bsize 512
> Oct 28 00:32:22 kefk kernel: uba: device 4 capacity nsec 1024000 bsize 512
> Oct 28 00:32:22 kefk kernel:  uba: uba1
> Oct 28 00:32:22 kefk kernel:  uba: uba1
> Oct 28 00:32:22 kefk kernel: kobject_register failed for uba1 (-17)

In your case, it's a bug which needs to be fixed. It hasn't got anything to
do with usb-storage or SCSI. But I'm still trying to find an approach which
works well. The basic problem is a combination of:
1. failure to start the device before calling add_disk
2. calling check_disk_change for all opens
3. returning a failure from media_present

If any of these conditions is removed, you will not see the problem.
I tried #1 for so-called "Key Distributed on Kernel Summit", but this
is not general enough, in particular your device appears resilient to that.

#2 would require distinguishing opens coming from user level from opens
called by the partition reading code, called indirectly from do_open.
I do not see how I can do that smoothly.

#3 causes the boolean logics on flags to become too involved.

-- Pete

  reply	other threads:[~2004-10-31 22:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.1099103401.11097.linux-kernel2news@redhat.com>
2004-10-30 16:15 ` Pete Zaitcev
2004-10-30 21:39   ` Adam Sampson
2004-10-31 22:10   ` Fabio Coatti
2004-10-31 22:57     ` Pete Zaitcev [this message]
2004-10-30  2:19 Paulo da Silva
2004-10-30 10:23 ` Pasi Savolainen
     [not found] ` <mailman.1099132081.20925.linux-kernel2news@redhat.com>
2004-11-23 17:50   ` Pete Zaitcev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041031145720.448d2ee9@lembas.zaitcev.lan \
    --to=zaitcev@redhat.com \
    --cc=cova@ferrara.linux.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=psdasilva@esoterica.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome