mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: ak@suse.de, linux-kernel@vger.kernel.org, pluto@pld-linux.org
Subject: Re: unit-at-a-time...
Date: Mon, 1 Nov 2004 12:10:29 +0100	[thread overview]
Message-ID: <20041101111029.GB24175@wotan.suse.de> (raw)
In-Reply-To: <200411011102.iA1B2jbX012340@harpo.it.uu.se>

> It happened when I added perfctr to a 2.6.5-based SuSE kernel,
> and compiled the whole thing with gcc-3.4.0 (or 3.4.1, don't
> remember). Perfctr normally adds a little stack usage to the
> context-switch path, but gcc-3.4 made it much worse.
> Disabling unit-at-a-time solved the problem.

Better fix would have been a few strategic "noinline"s.
If you want noinline just say it explicitely.

Also I hope they were not all in the same callchain,
if yes you would have only hidden the problem.

-Andi

  reply	other threads:[~2004-11-01 11:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-01 11:02 unit-at-a-time Mikael Pettersson
2004-11-01 11:10 ` Andi Kleen [this message]
     [not found] <200410311541.i9VFf0ah023857@harpo.it.uu.se.suse.lists.linux.kernel>
2004-11-01  1:39 ` unit-at-a-time Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2004-10-31 15:41 unit-at-a-time Mikael Pettersson
2004-10-31 16:18 ` unit-at-a-time Jan Engelhardt
2004-10-31 19:05 ` unit-at-a-time Roland Dreier
2004-10-31 21:33   ` unit-at-a-time Arjan van de Ven
2004-10-31 14:57 unit-at-a-time Paweł Sikora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041101111029.GB24175@wotan.suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@csd.uu.se \
    --cc=pluto@pld-linux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®