From: Russell King <rmk+lkml@arm.linux.org.uk>
To: David Vrabel <dvrabel@arcom.com>
Cc: Greg KH <greg@kroah.com>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] PCI: Add is_bridge to pci_dev to allow fixups to disable bridge functionality.
Date: Mon, 1 Nov 2004 11:34:58 +0000 [thread overview]
Message-ID: <20041101113458.A2117@flint.arm.linux.org.uk> (raw)
In-Reply-To: <41861701.3020008@arcom.com>; from dvrabel@arcom.com on Mon, Nov 01, 2004 at 10:59:13AM +0000
On Mon, Nov 01, 2004 at 10:59:13AM +0000, David Vrabel wrote:
> Greg KH wrote:
> > On Tue, Oct 19, 2004 at 12:22:49PM +0100, David Vrabel wrote:
> >
> >>The plan was to make the CardBus driver (drivers/pcmcia/yenta_socket.c)
> >>honour the is_bridge flag and not bother with CardBus stuff if it's cleared.
> >
> > But why can't any code that wants to check this, just look at the
> > dev->hdr_type instead? I don't think we need to add a new bit for this
> > because of that, right?
>
> Using the is_bridge flag allows PCI device fixups to disable the CardBus
> portion of the driver. And you obviously can't tweak the hdr_type since
> the device header is still a CardBus/bridge type header.
Why not make the PCI spaces for cardbus bridges configurable? Eg,
cardbusmem=1M cardbusio=8K
?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
prev parent reply other threads:[~2004-11-01 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 11:22 David Vrabel
2004-10-30 3:23 ` Greg KH
2004-11-01 10:59 ` David Vrabel
2004-11-01 11:34 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041101113458.A2117@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=dvrabel@arcom.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome