From: Oliver Neukum <oliver@neukum.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Chris Friesen <cfriesen@nortelnetworks.com>,
Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: question on common error-handling idiom
Date: Tue, 2 Nov 2004 22:21:55 +0100 [thread overview]
Message-ID: <200411022221.55857.oliver@neukum.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0411022208390.3285@dragon.hygekrogen.localhost>
> but for the places that do
>
> err = -SOMEERROR;
> if (condition)
> goto out;
>
> err = -OTHERERROR;
> if (condition)
> goto out;
>
> I would tend to agree with you that moving the setting of the error inside
> the if() would make sense.
The intention is to allow the compiler to turn the if into a simple
conditional branch on the assumption that gcc is not smart enough
to put the if's body out of line.
Regards
Oliver
next prev parent reply other threads:[~2004-11-02 21:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 20:08 Chris Friesen
2004-11-02 20:58 ` Jan Engelhardt
2004-11-02 21:12 ` linux-os
2004-11-03 10:45 ` Ross Kendall Axe
2004-11-02 21:12 ` Russell Miller
2004-11-02 21:16 ` Jesper Juhl
2004-11-02 21:21 ` Oliver Neukum [this message]
2004-11-02 21:29 ` Jan Engelhardt
2004-11-02 21:48 ` Jesper Juhl
2004-11-03 16:49 ` Chris Friesen
2004-11-03 8:11 ` GNicz
2004-11-04 19:52 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411022221.55857.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=cfriesen@nortelnetworks.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome