mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.de>
To: jgilbert@biomail.ucsd.edu, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: oops in 2.6.10-rc1-mm2 module_refcount
Date: Wed, 3 Nov 2004 16:17:44 +0100	[thread overview]
Message-ID: <20041103151744.GA12672@dominikbrodowski.de> (raw)
In-Reply-To: <20041103070419.GA8322@dominikbrodowski.de>

> Unable to handle kernel NULL pointer dereference at virtual address 000000a0
> printing eip:
> c0146807
> *pde = 00000000
> Oops: 0000 [#1]
> PREEMPT 
> Modules linked in:
> CPU:    0
> EIP:    0060:[<c0146807>]    Not tainted VLI
> EFLAGS: 00010282   (2.6.10-rc1-mm2-pleiades) 
> EIP is at module_refcount+0x7/0x10

module_refcount() on non-modules fails [in contrary to try_module_get()],
causing this bug when accessing /proc/bus/pccard/drivers and a pcmcia driver
is built into the kernel.

Applies on top of 
- pcmcia-17-device-model-integration.patch
- pcmcia-18a-client_t-and-pcmcia_device-integration.patch
- pcmcia-18b-error-on-leftover-devices.patch
- pcmcia-19-netdevice-integration.patch

Signed-off-by: Dominik Brodowski <linux@brodo.de>

--- linux/drivers/pcmcia/ds.c.original	2004-11-03 16:03:16.836857136 +0100
+++ linux/drivers/pcmcia/ds.c	2004-11-03 16:09:52.792662704 +0100
@@ -313,7 +313,7 @@
 
 	*p += sprintf(*p, "%-24.24s 1 %d\n", p_drv->drv.name, 
 #ifdef CONFIG_MODULE_UNLOAD
-		      module_refcount(p_drv->owner)
+		     (p_drv->owner) ? module_refcount(p_drv->owner) : 1
 #else
 		      1
 #endif

       reply	other threads:[~2004-11-03 15:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20041103070419.GA8322@dominikbrodowski.de>
2004-11-03 15:17 ` Dominik Brodowski [this message]
2004-11-03  5:59 John Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041103151744.GA12672@dominikbrodowski.de \
    --to=linux@dominikbrodowski.de \
    --cc=akpm@osdl.org \
    --cc=jgilbert@biomail.ucsd.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®