From: Matt Tolentino <metolent@snoqualmie.dp.intel.com>
To: arjan@infradead.org, metolent@snoqualmie.dp.intel.com
Cc: ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [patch] remove direct mem_map refs for x86-64
Date: Wed, 3 Nov 2004 09:24:21 -0800 [thread overview]
Message-ID: <200411031724.iA3HOLl0017096@snoqualmie.dp.intel.com> (raw)
>From SRS0+fff01e338c482ba0c24b+437+infradead.org+arjan@canuck.srs.infradead.org Wed Nov 3 08:54:21 2004
>On Wed, 2004-11-03 at 08:47 -0800, Matt Tolentino wrote:
>> - page = pgdat->node_mem_map + i;
>> - total++;
>> + page = pfn_to_page(pgdat->node_start_pfn + i);
>> + total++;
>
>this can't be correct... pfn_to_page starts to count from address 0
>while the original code starts from the start of the node..
Yep, you're right. I've been thinking about single nodes too much
lately.
matt
diff -urN linux-2.6.10-rc1-mm2-vanilla/arch/x86_64/mm/init.c linux-2.6.10-rc1-mm2/arch/x86_64/mm/init.c
--- linux-2.6.10-rc1-mm2-vanilla/arch/x86_64/mm/init.c 2004-11-03 06:50:01.939974040 -0500
+++ linux-2.6.10-rc1-mm2/arch/x86_64/mm/init.c 2004-11-03 07:26:15.922478464 -0500
@@ -466,7 +466,7 @@
/*
* Only count reserved RAM pages
*/
- if (page_is_ram(tmp) && PageReserved(mem_map+tmp))
+ if (page_is_ram(tmp) && PageReserved(pfn_to_page(tmp)))
reservedpages++;
#endif
next reply other threads:[~2004-11-03 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 17:24 Matt Tolentino [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-11-03 16:47 Matt Tolentino
2004-11-03 16:32 ` Arjan van de Ven
2004-11-03 17:02 ` Andi Kleen
2004-11-03 17:09 ` Arjan van de Ven
2004-11-03 17:01 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411031724.iA3HOLl0017096@snoqualmie.dp.intel.com \
--to=metolent@snoqualmie.dp.intel.com \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®