From: Chris Wedgwood <cw@f00f.org>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
urban@teststation.com
Subject: Re: [PATCH 2.6.10-rc1] Fix building of samba userland
Date: Wed, 3 Nov 2004 12:55:48 -0800 [thread overview]
Message-ID: <20041103205548.GA10756@taniwha.stupidest.org> (raw)
In-Reply-To: <20041103190345.GI381@smtp.west.cox.net>
On Wed, Nov 03, 2004 at 12:03:45PM -0700, Tom Rini wrote:
> Hello. After 2.6.8.1, samba userland would no longer build with
> current kernel headers, as it needs some of the samba kernel headers
> to work,
what? the samba userland which i assume is portable and not at all
linux specific needs linux kernel headers?
> +++ edited/include/linux/smb_fs.h 2004-11-03 12:00:07 -07:00
> @@ -12,7 +12,6 @@
> #include <linux/smb.h>
> #include <linux/smb_fs_i.h>
> #include <linux/smb_fs_sb.h>
> -#include <linux/fs.h>
>
> /*
> * ioctl commands
> @@ -26,6 +25,7 @@
>
> #ifdef __KERNEL__
>
> +#include <linux/fs.h>
> #include <linux/pagemap.h>
> #include <linux/vmalloc.h>
> #include <linux/smb_mount.h>
that patch seems harmless enough, but im not sure why it should be
necessary really, i dont see why samba should be including such
headers at all --- it's a bad idea in almost all cases
next prev parent reply other threads:[~2004-11-03 21:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 19:03 Tom Rini
2004-11-03 20:55 ` Chris Wedgwood [this message]
2004-11-03 21:32 ` Tom Rini
2004-11-03 21:33 ` Chris Wedgwood
2004-11-03 21:42 ` Tom Rini
2004-11-03 21:45 ` Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041103205548.GA10756@taniwha.stupidest.org \
--to=cw@f00f.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
--cc=urban@teststation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®