From: Chris Wedgwood <cw@f00f.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/3] WIN_* -> ATA_CMD_* conversion: comments
Date: Fri, 5 Nov 2004 19:22:59 -0800 [thread overview]
Message-ID: <20041106032259.GA6060@taniwha.stupidest.org> (raw)
In-Reply-To: <58cb370e041105051635c15281@mail.gmail.com>
On Fri, Nov 05, 2004 at 02:16:05PM +0100, Bartlomiej Zolnierkiewicz wrote:
> On Thu, 04 Nov 2004 21:43:12 -0500, Jeff Garzik <jgarzik@pobox.com> wrote:
> > Chris, a useful follow-up patch (if Bart agrees) is a global
> > search-n-replace of WIN_xxx constants with ATA_CMD_xxx constants.
> > Depending on the size of the patch, it might even need to be split
> > up across several patches.
Following are three patches doing just thus. They are against bk TOT
with Bart's IDE tree pulled in.
> One ceveat here: hdreg.h and WIN_xxx are (ab)used by user-space so
> for sure there will be complaints (not that we should care :)...
They should fork the values they need then, they are not kernel
specific but come from some nightmarish specification :)
About the following patches:
The first patch adds missing ATA_CMD_* values which the legacy
code will need.
The second patch updates the legacy code (and a couple of
stragglers) to use the new ATA_CMD_* tokens.
The third patch removes the (then) redundant cruft from hdreg.h.
next prev parent reply other threads:[~2004-11-06 3:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-03 9:11 [PATCH] IDE remove some cruft from ide.h Chris Wedgwood
2004-11-05 2:43 ` Jeff Garzik
2004-11-05 13:16 ` Bartlomiej Zolnierkiewicz
2004-11-06 3:22 ` Chris Wedgwood [this message]
2004-11-06 3:23 ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion: add new entries to ata.h Chris Wedgwood
2004-11-06 16:48 ` Jeff Garzik
2004-11-06 17:05 ` Jeff Garzik
2004-11-07 6:04 ` [PATCH 0/3] WIN_* -> ATA_CMD_* conversion (take #2): comments Chris Wedgwood
2004-11-07 6:04 ` [PATCH 1/3] WIN_* -> ATA_CMD_* conversion (take #2): add new entries to ata.h Chris Wedgwood
2004-11-08 2:30 ` Jeff Garzik
2004-11-07 6:04 ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion (take #2): convert users of WIN_* to ATA_CMD_* Chris Wedgwood
2004-11-07 6:04 ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion (take #2): cleanup hdreg.h Chris Wedgwood
2004-11-06 3:23 ` [PATCH 2/3] WIN_* -> ATA_CMD_* conversion: update WIN_* users to use ATA_CMD_* Chris Wedgwood
2004-11-06 3:45 ` Ross Biro
2004-11-06 3:55 ` Chris Wedgwood
2004-11-06 14:53 ` Ross Biro
2004-11-08 8:55 ` Jens Axboe
2004-11-06 3:23 ` [PATCH 3/3] WIN_* -> ATA_CMD_* conversion: cleanup hdreg.h Chris Wedgwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041106032259.GA6060@taniwha.stupidest.org \
--to=cw@f00f.org \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®