From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261577AbUKGLUG (ORCPT ); Sun, 7 Nov 2004 06:20:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261580AbUKGLUG (ORCPT ); Sun, 7 Nov 2004 06:20:06 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:21011 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S261577AbUKGLUC (ORCPT ); Sun, 7 Nov 2004 06:20:02 -0500 Date: Sun, 7 Nov 2004 11:19:55 +0000 From: Russell King To: Geert Uytterhoeven , Linus Torvalds , Andrew Morton , Linux Kernel Development Subject: Re: [PATCH 478] M68k SERIAL_PORT_DFNS only if CONFIG_ISA Message-ID: <20041107111955.B27505@flint.arm.linux.org.uk> Mail-Followup-To: Geert Uytterhoeven , Linus Torvalds , Andrew Morton , Linux Kernel Development References: <200410311003.i9VA3ZVQ009578@anakin.of.borg> <20041031171544.A17342@flint.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20041031171544.A17342@flint.arm.linux.org.uk>; from rmk+lkml@arm.linux.org.uk on Sun, Oct 31, 2004 at 05:15:44PM +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 31, 2004 at 05:15:44PM +0000, Russell King wrote: > On Sun, Oct 31, 2004 at 11:03:35AM +0100, Geert Uytterhoeven wrote: > > M68k serial: Only define SERIAL_PORT_DFNS when CONFIG_ISA is defined. Otherwise > > the first 4 slots in the 8250 driver are unavailable on non-ISA machines. > > (from Kars de Jong) > > I won't be applying this patch - you may wish to consider doing this an > alternative way once the contents of my BK tree becomes public. > > include/asm-*/serial.h is almost dead! Long live serial.h! Geert, The changes are now in - please look again about defining SERIAL_PORT_DFNS even for the CONFIG_ISA case. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core