Re: 2.4.28-rc2: net/atm/proc.c compile error

[Willy Tarreau <willy@w.ods.org>]

Hi David,

On Sun, Nov 07, 2004 at 05:42:47PM -0800, David S. Miller wrote:
 
> You must have mispatched, here is a grep I just did in Marcelo's
> current tree:
> 
> davem@nuts:/disk1/BK/marcelo-2.4/net/atm$ egrep atm_lec_info *.c
> davem@nuts:/disk1/BK/marcelo-2.4/net/atm$ 

No, he patched it right, I got it too and found where it broke :

gcc -D__KERNEL__ -I/data/projets/dev/linux/trees/linux-2.4.28-rc2/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mno-fp-regs -ffixed-8 -mcpu=ev6 -Wa,-mev6 -DMODULE  -nostdinc -iwithprefix include -DKBUILD_BASENAME=proc  -DEXPORT_SYMTAB -c proc.c
proc.c: In function `atm_proc_init':
proc.c:624: error: `atm_lec_info' undeclared (first use in this function)
proc.c:624: error: (Each undeclared identifier is reported only once
proc.c:624: error: for each function it appears in.)
make[2]: *** [proc.o] Error 1

----- net/atm/proc.c: -------

#define CREATE_ENTRY(name) \
    name = create_proc_entry(#name,0,atm_proc_root); \
    if (!name) goto cleanup; \
    name->data = atm_##name##_info; \
    name->proc_fops = &proc_spec_atm_operations; \
    name->owner = THIS_MODULE
...
623: #if defined(CONFIG_ATM_LANE) || defined(CONFIG_ATM_LANE_MODULE)
624:        CREATE_ENTRY(lec);
625: #endif

That's why your grep did not find it ;-)
Is it enough to remove these 3 lines ?

Regards,
Willy