From: Andrew Morton <akpm@osdl.org>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: linux-kernel@vger.kernel.org, hunold@linuxtv.org
Subject: Re: [patch 1/6] v4l: yet another video-buf interface update
Date: Mon, 8 Nov 2004 13:52:22 -0800 [thread overview]
Message-ID: <20041108135222.5edde9f9.akpm@osdl.org> (raw)
In-Reply-To: <20041108085116.GA19146@bytesex>
Gerd Knorr <kraxel@bytesex.org> wrote:
>
> This is one more interface fix for the video-buf.c module, the first
> attempt on that wasn't that clever. Instead of passing the driver
> private data through all function calls I've just made that an element
> of the videobuf_queue struct which is passed around everythere _anyway_.
This patch throws a reject in videobuf_vm_close() because it's expecting
map->q->ops->buf_release(vma->vm_file,map->q->bufs[i]);
and not
map->q->ops->buf_release(vma->vm_file->private_data,map->q->bufs[i]);
I'll fix things up, but please check that.
next prev parent reply other threads:[~2004-11-08 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-08 8:51 Gerd Knorr
2004-11-08 21:52 ` Andrew Morton [this message]
2004-11-08 23:00 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041108135222.5edde9f9.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hunold@linuxtv.org \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®