From: Sam Ravnborg <sam@ravnborg.org>
To: Zbigniew Szmek <zjedrzejewski-szmek@wp.pl>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make crypto modular
Date: Mon, 8 Nov 2004 23:23:20 +0100 [thread overview]
Message-ID: <20041108222320.GA16150@mars.ravnborg.org> (raw)
In-Reply-To: <200411082149.54723.zjedrzejewski-szmek@wp.pl>
On Mon, Nov 08, 2004 at 09:49:54PM +0100, Zbigniew Szmek wrote:
diff -rupN 2610rc1mm1.um/crypto.modular/Makefile 2610rc1mm1.um/crypto/Makefile
> --- 2610rc1mm1.um/crypto.modular/Makefile 2004-11-07 18:41:35.000000000 +0100
> +++ 2610rc1mm1.um/crypto/Makefile 2004-11-08 11:44:52.000000000 +0100
> @@ -2,12 +2,13 @@
> # Cryptographic API
> #
>
> -proc-crypto-$(CONFIG_PROC_FS) = proc.o
> +obj-$(CONFIG_CRYPTO) += crypto.o
>
> -obj-$(CONFIG_CRYPTO) += api.o scatterwalk.o cipher.o digest.o compress.o \
> - $(proc-crypto-y)
> +crypto-objs = $(crypto-objs-y)
> +crypto-objs-y = api.o scatterwalk.o cipher.o digest.o compress.o
> +crypto-objs-$(CONFIG_PROC_FS) += proc.o
> +crypto-objs-$(CONFIG_CRYPTO_HMAC) += hmac.o
Please use:
crypto-y := api.o scatterwalk.o cipher.o digest.o compress.o
crypto-$(CONFIG_PROC_FS) += proc.o
crypto-$(CONFIG_CRYPTO_HMAC) += hmac.o
More compact and nicer format.
I did not look through the rest of the changes.
Sam
next prev parent reply other threads:[~2004-11-08 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-08 20:49 Zbigniew Szmek
2004-11-08 22:23 ` Sam Ravnborg [this message]
2004-11-09 0:02 ` Zbigniew Szmek
2004-11-12 8:45 ` James Morris
2004-11-10 19:38 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041108222320.GA16150@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zjedrzejewski-szmek@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®