mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Kirill Korotaev <dev@sw.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: 4/4GB:
Date: Fri, 12 Nov 2004 21:22:29 +0100	[thread overview]
Message-ID: <20041112202229.GB15256@elte.hu> (raw)
In-Reply-To: <41939163.5020305@sw.ru>


* Kirill Korotaev <dev@sw.ru> wrote:

>  #define __RESTORE_REGS	\
>  	__RESTORE_INT_REGS; \
> +	popl %ds;	\
> +	popl %es;
> +
> +#define __RESTORE_REGS_USER \
> +	__RESTORE_INT_REGS; \
>  111:	popl %ds;	\
>  222:	popl %es;	\
> -.section .fixup,"ax";	\
> +	jmp 666f;	\
>  444:	movl $0,(%esp);	\
>  	jmp 111b;	\
>  555:	movl $0,(%esp);	\
>  	jmp 222b;	\
> -.previous;		\
> +666:			\
>  .section __ex_table,"a";\
>  	.align 4;	\
>  	.long 111b,444b;\
> @@ -220,6 +225,13 @@ int80_ret_end_marker:					\
>  
>  #define __RESTORE_ALL	\
>  	__RESTORE_REGS	\
> +	__RESTORE_IRET
> +
> +#define __RESTORE_ALL_USER \
> +	__RESTORE_REGS_USER \
> +	__RESTORE_IRET
> +
> +#define __RESTORE_IRET	\
>  	addl $4, %esp;	\
>  333:	iret;		\
>  .section .fixup,"ax";   \

looks fine and necessary. Fundamental bugs in this area tend to show up
as instant reboots, so i'm sure if you broke this code you'll quickly
notice it ...

	Ingo

      reply	other threads:[~2004-11-12 19:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-11 16:20 Kirill Korotaev
2004-11-12 20:22 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041112202229.GB15256@elte.hu \
    --to=mingo@elte.hu \
    --cc=dev@sw.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®