From: William Lee Irwin III <wli@holomorphy.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: jgarzik@pobox.com, viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: Parenthize nth_page() macro arg, in linux/mm.h.
Date: Sat, 13 Nov 2004 22:10:16 -0800 [thread overview]
Message-ID: <20041114061016.GF3217@holomorphy.com> (raw)
In-Reply-To: <200411140517.iAE5HOqM010399@hera.kernel.org>
On Sat, Nov 13, 2004 at 07:43:08PM +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.2092.7.2, 2004/11/13 14:43:08-05:00, jgarzik@pobox.com
> Parenthize nth_page() macro arg, in linux/mm.h.
> mm.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
> diff -Nru a/include/linux/mm.h b/include/linux/mm.h
> --- a/include/linux/mm.h 2004-11-13 21:17:35 -08:00
> +++ b/include/linux/mm.h 2004-11-13 21:17:35 -08:00
> @@ -41,7 +41,7 @@
> #define MM_VM_SIZE(mm) TASK_SIZE
> #endif
> -#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + n)
> +#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))
Okay, #1 the ((page)) thing should be unnecessary. If it is necessary,
arch code is broken, which leads to #2: this came about because alpha
wasn't parenthesizing its args in pfn_to_page(); where did the fix for
that go?
-- wli
next parent reply other threads:[~2004-11-14 6:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200411140517.iAE5HOqM010399@hera.kernel.org>
2004-11-14 6:10 ` William Lee Irwin III [this message]
2004-11-14 6:18 ` Al Viro
2004-11-14 6:23 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041114061016.GF3217@holomorphy.com \
--to=wli@holomorphy.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome