From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261748AbUKPCeR (ORCPT ); Mon, 15 Nov 2004 21:34:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261761AbUKPCeR (ORCPT ); Mon, 15 Nov 2004 21:34:17 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:13465 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S261748AbUKPCeF (ORCPT ); Mon, 15 Nov 2004 21:34:05 -0500 Date: Tue, 16 Nov 2004 02:34:04 +0000 From: Matthew Wilcox To: Adrian Bunk Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] SCSI ncr53c8xx.c: make a variable static Message-ID: <20041116023404.GD26623@parcelfarce.linux.theplanet.co.uk> References: <20041115021612.GR2249@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041115021612.GR2249@stusta.de> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 15, 2004 at 03:16:12AM +0100, Adrian Bunk wrote: > The patch below makes a needlessly global variable static. This needs to be taken care of as part of a module_param conversion. Something similar to the sym2 conversion, I think ... -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain