From: Andrew Morton <akpm@osdl.org>
To: Giuseppe Sacco <giuseppe@eppesuigoccas.homedns.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/video/gbefb.c
Date: Wed, 17 Nov 2004 19:57:24 -0800 [thread overview]
Message-ID: <20041117195724.672f3793.akpm@osdl.org> (raw)
In-Reply-To: <1100735917.7866.11.camel@localhost>
Giuseppe Sacco <giuseppe@eppesuigoccas.homedns.org> wrote:
>
> The current gbefb.c source cannot be compiled as module because of a
> small typo where "option" was written instead of "options" in two
> places.
>
> Here is a small patch that fixes it. May anyone apply it?
Yup, I can take care of that, thanks.
In future, please use `diff -u' to generate `patch -p1' form patches. Like
this:
--- 25/drivers/video/gbefb.c
+++ 25-akpm/drivers/video/gbefb.c
@@ -1084,9 +1084,9 @@ int __init gbefb_init(void)
int i, ret = 0;
#ifndef MODULE
- char *option = NULL;
+ char *options = NULL;
- if (fb_get_options("gbefb", &option))
+ if (fb_get_options("gbefb", &options))
return -ENODEV;
gbefb_setup(options);
#endif
_
prev parent reply other threads:[~2004-11-18 3:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-17 23:58 Giuseppe Sacco
2004-11-18 3:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041117195724.672f3793.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=giuseppe@eppesuigoccas.homedns.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®