mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Colin Leroy <colin@colino.net>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: hotplug_path no longer exported
Date: Wed, 17 Nov 2004 23:12:53 +0100	[thread overview]
Message-ID: <20041117231253.1ec92e6f.colin@colino.net> (raw)
In-Reply-To: <20041117214824.GA1291@kroah.com>

On 17 Nov 2004 at 13h11, Greg KH wrote:

Hi, 

> > hotplug_path is no longer exported, is this on purpose ?
> 
> Yes.
> 
> > It breaks linux-wlan-ng. If it is on purpose, I suppose
> > linux-wlan-ng should use kobject_hotplug() ?
> 
> Yes it should.  Why was it not useing that function in the first
> place?

Dunno. This driver has a reputation of being the worse wlan driver for
prism2 chipsets out there, but it's the only one supporting USB devices.

> No, please use kobject_hotplug().  Actually, what are they doing that
> they need to call kobject_hotplug() in the first place?

To propagate events to scripts, I think:
void    p80211_suspend(wlandevice_t *wlandev)
{
	p80211_run_sbin_hotplug(wlandev, WLAN_HOTPLUG_SUSPEND);
}
int register_wlandev(wlandevice_t *wlandev)
{
	netdevice_t	*dev = wlandev->netdev;
...	if (register_netdev(dev)) {
		return -EIO;
	}
...
	p80211_run_sbin_hotplug(wlandev, WLAN_HOTPLUG_REGISTER);
}

With p80211_run_sbin_hotplug doing stuff to call /sbin/hotplug... 
The one that will write a correct patch to linux-wlan-ng will have to
figure out the different events they use: "register" (instead of "add"),
"startup", "shutdown", "resume", "suspend"...

-- 
Colin
  http://www.colino.net/

  reply	other threads:[~2004-11-17 22:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-17 19:31 Colin Leroy
2004-11-17 21:48 ` Greg KH
2004-11-17 22:12   ` Colin Leroy [this message]
2004-11-17 22:23     ` Greg KH
2004-11-18  8:17       ` Colin Leroy
2004-11-18 10:06       ` Joshua Kwan
2004-11-18 10:19         ` Colin Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041117231253.1ec92e6f.colin@colino.net \
    --to=colin@colino.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®