mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Chris Wright <chrisw@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Linus Torvalds <torvalds@osdl.org>,
	Tony Luck <tony.luck@intel.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] setup_arg_pages can insert overlapping vma
Date: Thu, 18 Nov 2004 10:55:46 -0800	[thread overview]
Message-ID: <20041118105546.Q2357@build.pdx.osdl.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0411181720550.2971-100000@localhost.localdomain>; from hugh@veritas.com on Thu, Nov 18, 2004 at 05:39:59PM +0000

* Hugh Dickins (hugh@veritas.com) wrote:
> On Tue, 16 Nov 2004, Chris Wright wrote:
> > Florian Heinz built an a.out binary that could map bss from 0x0 to
> > 0xc0000000, and setup_arg_pages() would BUG() in insert_vma_struct
> > because the arg pages overlapped.  This just checks before inserting,
> > and bails out if it would overlap.
> 
> Chris, shouldn't your patch also cover the setup_arg_pages clones for
> 32-bit support on 64-bit architectures, with something - uncompiled,
> untested - like the below?  I'm not sure how necessary the additional
> vma->vm_start < mpnt->vm_end test is, but suspect ia64 might need it.

I expect other arches should need the fix as well, it would be nice
to test them.  I'm not clear on that extra test.  Wouldn't it imply
vm_end < vm_start?

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2004-11-18 18:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-16 23:19 Chris Wright
2004-11-16 23:23 ` [PATCH 2/2] a.out: error check on set_brk Chris Wright
2004-11-18 17:39 ` [PATCH 1/2] setup_arg_pages can insert overlapping vma Hugh Dickins
2004-11-18 18:55   ` Chris Wright [this message]
2004-11-18 19:41     ` Hugh Dickins
2004-11-18 20:07       ` Chris Wright
2004-11-24  1:04 Zou, Nanhai
2004-11-24  1:23 ` Andrew Morton
2004-11-24 10:45   ` Andi Kleen
2004-11-24 16:30 ` Hugh Dickins
2004-11-24 20:38 ` Chris Wright
     [not found] <20041124152250.GA4797@mschwid3.boeblingen.de.ibm.com>
2004-11-24 16:41 ` Hugh Dickins
2004-11-24 17:51 Luck, Tony
2004-11-25  0:44 Zou, Nanhai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041118105546.Q2357@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tony.luck@intel.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome