Re: [PATCH] usb-storage should enable scsi disk in Kconfig

[Matthew Dharm <mdharm-kernel@one-eyed-alien.net>]

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

On Fri, Nov 19, 2004 at 10:39:42PM +0100, Stelian Pop wrote:
> On Fri, Nov 19, 2004 at 07:57:36PM +0000, Christoph Hellwig wrote:
> 
> > On Fri, Nov 19, 2004 at 08:33:50PM +0100, Stelian Pop wrote:
> > > As $subject says, usb-storage storage should automatically enable
> > > scsi disk support in Kconfig.
> > > 
> > > Please apply.
> > 
> > No, it shouldn't.  There's lots of usb storage devices that don't use
> > sd, as there are lots of SPI/FC/etc.. devices.
> 
> Indeed, I should have checked more carefully. My bad.
> 
> Still, it is not obvious that one should go into a completly different
> config section and manually enable sd support, and I have been bitten
> by this more than one time.
> 
> Maybe we should add, just below the 'USB storage' Kconfig option another
> one, let's say 'SCSI disk based USB storage support', which documentation
> would talk about 'usb keys, memory stick readers, USB floppy drives etc',
> which should just be a dummy option selecting  BLK_DEV_SD ?
> 
> Or perhaps we should add something along the Debian's dpkg 'suggests' rule
> to Kconfig ? :)

I get enough e-mail on this topic that we should do something about it.
We need some sort of 'suggests' rule, or at least some sort of message to
the user to tell them to enable the high-level drivers.

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

What, are you one of those Microsoft-bashing Linux freaks?
					-- Customer to Greg
User Friendly, 2/10/1999

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]