mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: hch@infradead.org, torvalds@osdl.org, jongk@linux-m68k.org,
	jgarzik@pobox.com, linux-kernel@vger.kernel.org,
	linux-net@vger.kernel.org
Subject: Re: [PATCH 475] HP300 LANCE
Date: Sun, 21 Nov 2004 16:12:44 -0800	[thread overview]
Message-ID: <20041121161244.1a5ff193.akpm@osdl.org> (raw)
In-Reply-To: <Pine.GSO.4.61.0411211059500.19680@waterleaf.sonytel.be>

Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Tue, 16 Nov 2004, Andrew Morton wrote:
> > Christoph Hellwig <hch@infradead.org> wrote:
> > > > There's tons of leaks in the hplcance probing code, and it doesn't release
> > >  > he memory region on removal either.
> > >  > 
> > >  > Untested patch to fix those issues below:
> > > 
> > >  ping.
> > 
> > The fix needs a fix:
> 
> Indeed.
> 
> And you should remove the definitions of dio_resource_{start,len}(), as they're
> already defined in linux/dio.h.
> 

But differently.   Christoph had:

+#define dio_resource_len(d) \
+       ((d)->resource.end - (d)->resource.start)

but dio.h has:

#define dio_resource_len(d)   ((d)->resource.end-(z)->resource.start+1)


Which is correct?

  parent reply	other threads:[~2004-11-22  0:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-31 10:03 Geert Uytterhoeven
2004-10-31 10:14 ` Jeff Garzik
2004-10-31 10:19   ` Andrew Morton
2004-10-31 10:41     ` Jeff Garzik
2004-10-31 10:48       ` Andrew Morton
2004-10-31 10:57         ` Jeff Garzik
2004-10-31 11:09           ` Andrew Morton
2004-10-31 11:44             ` Geert Uytterhoeven
2004-10-31 11:50             ` Herbert Xu
2004-10-31 11:58               ` Jeff Garzik
2004-11-01 14:22 ` Christoph Hellwig
2004-11-16  8:43   ` Christoph Hellwig
2004-11-17  7:12     ` Andrew Morton
2004-11-21 10:01       ` Geert Uytterhoeven
2004-11-21 11:19         ` Kars de Jong
2004-11-22  0:12         ` Andrew Morton [this message]
2004-11-22  0:25           ` Sohail Somani
2004-11-22 10:54             ` Geert Uytterhoeven
2004-11-22  8:26           ` Geert Uytterhoeven
2004-11-01  3:46 Chuck Ebbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041121161244.1a5ff193.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=geert@linux-m68k.org \
    --cc=hch@infradead.org \
    --cc=jgarzik@pobox.com \
    --cc=jongk@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®