From: Andrew Morton <akpm@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] del_timer() vs. mod_timer() SMP race
Date: Sun, 21 Nov 2004 18:54:39 -0800 [thread overview]
Message-ID: <20041121185439.7fcfe514.akpm@osdl.org> (raw)
In-Reply-To: <1101091445.13612.31.camel@gaston>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> --- linux-work.orig/kernel/timer.c 2004-11-22 11:50:59.000000000 +1100
> +++ linux-work/kernel/timer.c 2004-11-22 13:35:38.928448032 +1100
> @@ -308,6 +308,7 @@
> goto repeat;
> }
> list_del(&timer->entry);
> + smp_wmb();
Pretty please, always add a comment when putting an open-coded barrier into
the kernel. Otherwise people cannot tell why it is there.
next prev parent reply other threads:[~2004-11-22 2:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-22 2:44 Benjamin Herrenschmidt
2004-11-22 2:54 ` Andrew Morton [this message]
2004-11-22 3:03 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041121185439.7fcfe514.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®